libadblockplus.gyp - Issue 10100009: FilterEngine API improvements

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: libadblockplus.gyp

Issue 10100009: FilterEngine API improvements (Closed)

Patch Set: Added filter access and addressed review comments Created April 5, 2013, 12:10 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
1 {	1 {

2 'includes': ['third_party/v8/build/common.gypi',	2 'includes': ['third_party/v8/build/common.gypi',

3 'shell/shell.gyp'],	3 'shell/shell.gyp'],

4 'targets': [{	4 'targets': [{

5 'target_name': 'libadblockplus',	5 'target_name': 'libadblockplus',

6 'type': '<(library)',	6 'type': '<(library)',

7 'include_dirs': [	7 'include_dirs': [

8 'include',	8 'include',

9 'third_party/v8/include'	9 'third_party/v8/include'

10 ],	10 ],

(...skipping 49 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
60 '<@(core_library_files)',	60 '<@(core_library_files)',

61 '--',	61 '--',

62 '<@(additional_library_files)',	62 '<@(additional_library_files)',

63 '<@(_outputs)',	63 '<@(_outputs)',

64 ]	64 ]

65 }]	65 }]

66 },	66 },

67 {	67 {

68 'target_name': 'tests',	68 'target_name': 'tests',

69 'type': 'executable',	69 'type': 'executable',

	70 'defines': ['FILTER_ENGINE_STUBS=1'],

70 'dependencies': [	71 'dependencies': [

71 'third_party/googletest.gyp:googletest_main',	72 'third_party/googletest.gyp:googletest_main',

72 'libadblockplus'	73 'libadblockplus'

73 ],	74 ],

74 'sources': [	75 'sources': [

75 'test/ConsoleJsObject.cpp',	76 'test/ConsoleJsObject.cpp',

76 'test/FilterEngineStubs.cpp',	77 'test/FilterEngineStubs.cpp',

77 'test/JsEngine.cpp',	78 'test/JsEngine.cpp',

78 'test/Thread.cpp'	79 'test/Thread.cpp'

79 ]	80 ]

80 }]	81 }]

81 }	82 }

OLD	NEW