Make sure subprocess calls don`t ignore result codes indicating errors. Fix JS docs generation whil…

sitescripts/management/bin/generateHgAuth.py

 # coding: utf-8
 
 # This file is part of the Adblock Plus web scripts,
 # Copyright (C) 2006-2013 Eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 # GNU General Public License for more details.
 #
 # You should have received a copy of the GNU General Public License
 # along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
 
 import os, re, sys, subprocess, tarfile
 from StringIO import StringIO
 from sitescripts.utils import get_config, setupStderr
 
 def generateData(authRepo):
   command = ['hg', '-R', authRepo, 'archive', '-r', 'default', '-t', 'tar', '-p', '.', '-']
-  (data, dummy) = subprocess.Popen(command, stdout=subprocess.PIPE).communicate()
+  data = subprocess.check_output(command)
 
   users = {}
   repos = []
   tarFile = tarfile.open(mode='r:', fileobj=StringIO(data))
   fileInfo = tarFile.next()
   while fileInfo:
     name = fileInfo.name
     if name.startswith('./'):
       name = name[2:]
 
@@ skipping 56 matching lines @@
 
   result = generateData(get_config().get('hg', 'auth_repository'))
 
   file = open(get_config().get('hg', 'auth_file'), 'wb')
   for s in result:
     file.write(s)
   file.close()
 
 if __name__ == '__main__':
   hook()