Make sure subprocess calls don`t ignore result codes indicating errors. Fix JS docs generation whil…

sitescripts/management/bin/installChanges.py

 # coding: utf-8
 
 # This file is part of the Adblock Plus web scripts,
 # Copyright (C) 2006-2013 Eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
@@ skipping 18 matching lines @@
 def chown((uid, gid), dirname, names):
   for name in names:
     os.chown(os.path.join(dirname, name), uid, gid)
     if (name.endswith('.fcgi') or name.endswith('.sh') or name.endswith('.pl')):
       os.chmod(os.path.join(dirname, name), 0755)
 
 def syncFiles(name, settings, syncState):
   repo, path = splitRepositoryPath(settings['source'])
 
   command = ['hg', 'log', '-R', repo, '-r', 'default', '--template', '{node|short}']
-  currentRevision, dummy = subprocess.Popen(command, stdout=subprocess.PIPE).communicate()
+  currentRevision = subprocess.check_output(command)
 
   if not syncState.has_section(name):
     syncState.add_section(name)
   if syncState.has_option(name, 'latestRevision') and currentRevision == syncState.get(name, 'latestRevision'):
     # Already up to date, nothing to do
     return
 
   tempdir = tempfile.mkdtemp(prefix=name)
   try:
     command = ['hg', 'archive', '-R', repo, '-r', 'default',
       '-I', os.path.join(repo, path),
       '-X', os.path.join(repo, '.hg_archival.txt'),
       '-X', os.path.join(repo, '.hgtags'),
       '-X', os.path.join(repo, '.hgignore'),
       '-X', os.path.join(repo, '.hgsub'),
       '-X', os.path.join(repo, '.hgsubstate'),
       tempdir]
 
-    subprocess.Popen(command, stdout=subprocess.PIPE).communicate()
+    subprocess.check_output(command)
     srcdir = os.path.normpath(os.path.join(tempdir, path))
     for relpath in settings['ignore']:
       abspath = os.path.join(srcdir, relpath)
       if os.path.commonprefix((abspath, srcdir)) == srcdir and os.path.exists(abspath):
         shutil.rmtree(abspath)
 
     if hasattr(os, 'chown') and settings['user'] and settings['group']:
       from pwd import getpwnam
       from grp import getgrnam
       uid = getpwnam(settings['user']).pw_uid
       gid = getgrnam(settings['group']).gr_gid
       os.path.walk(srcdir, chown, (uid, gid))
       os.chmod(srcdir, 0755)
       os.chown(srcdir, uid, gid)
 
     command = ['rsync', '-a', '--delete']
     for relpath in settings['ignore']:
       abspath = os.path.join(settings['target'], relpath)
       if os.path.commonprefix((abspath, settings['target'])) == settings['target'] and os.path.lexists(abspath):
         command.append('--exclude')
         if os.path.isdir(abspath) and not os.path.islink(abspath):
           command.append(os.path.join(relpath, ''))
         else:
           command.append(relpath)
     command.append(os.path.join(srcdir, ''))
     command.append(settings['target'])
-    subprocess.Popen(command, stdout=subprocess.PIPE).communicate()
+    subprocess.check_output(command)
 
     if settings['postsync']:
-      subprocess.Popen(settings['postsync'], stdout=subprocess.PIPE, shell=True, cwd=settings['target']).communicate()
+      subprocess.check_output(settings['postsync'], shell=True, cwd=settings['target'])
 
     syncState.set(name, 'latestRevision', currentRevision)
   finally:
     shutil.rmtree(tempdir, ignore_errors=True)
 
 def readSyncSettings():
   result = {}
   for option in get_config().options('filesync'):
     if option.find('_') < 0:
       continue
@@ skipping 23 matching lines @@
   syncStateFile = get_config().get('filesync', 'syncData')
   if os.path.exists(syncStateFile):
     syncState.read(syncStateFile)
 
   settings = readSyncSettings()
   for name, value in settings.iteritems():
     syncFiles(name, value, syncState)
 
   file = open(syncStateFile, 'wb')
   syncState.write(file)