Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: sitescripts/management/bin/start_services.py

Issue 10942098: Make sure subprocess calls don`t ignore result codes indicating errors. Fix JS docs generation whil… (Closed)
Patch Set: Fixed wrong argument format Created July 4, 2013, 1:01 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sitescripts/management/bin/start_services.py
===================================================================
--- a/sitescripts/management/bin/start_services.py
+++ b/sitescripts/management/bin/start_services.py
@@ -53,9 +53,9 @@ if __name__ == "__main__":
print "'%s' is not a PID." % pid_string
init_path = os.path.join("/etc/init.d", service)
if not os.path.exists(init_path):
print "%s does not exist, service is not running and cannot be started." % init_path
continue
print "%s is not running, starting ..." % service
- subprocess.call([init_path, "start"])
+ subprocess.check_call([init_path, "start"])

Powered by Google App Engine
This is Rietveld