Make sure subprocess calls don`t ignore result codes indicating errors. Fix JS docs generation whil…

sitescripts/subscriptions/knownIssuesParser.py

Index: sitescripts/subscriptions/knownIssuesParser.py
===================================================================
--- a/sitescripts/subscriptions/knownIssuesParser.py
+++ b/sitescripts/subscriptions/knownIssuesParser.py
@@ -145,20 +145,17 @@ def extractMatches(rules, rulesets, lang
   result = result.keys()
   result.sort()
   return result
 
 @cached(600)
 def getRules():
   repoPath = os.path.abspath(get_config().get('subscriptions', 'repository'))
 
-  (data, errors) = subprocess.Popen(['hg', '-R', repoPath, 'cat', '-r', 'default', os.path.join(repoPath, 'knownIssues')], stdout=subprocess.PIPE, stderr=subprocess.PIPE).communicate()
-  if errors:
-    print >>sys.stderr, errors
-
+  data = subprocess.check_output(['hg', '-q', '-R', repoPath, 'cat', '-r', 'default', os.path.join(repoPath, 'knownIssues')])

[Sebastian Noack, 2013/07/04 13:57:51]

The added -q parameter doesn't seem to have any affect, because of neither the
ouput of the content of the given file, nor error messages are affected by hg's
-q parameter.

[Wladimir Palant, 2013/07/05 11:24:33]

Oops, I was a bit over-eager adding -q to all hg commands - check_output() calls
obviously don't need it.

   data = data.decode('utf-8').replace('\r', '').split('\n')
   data.append('[]')   # Pushes out last section
 
   rules = {}
   rulesets = []
 
   ruleset = None
   for line in data: