Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: chrome/content/ui/composer.js

Issue 11015083: Merge labels and access keys into one string in locales (Closed)
Patch Set: Created July 3, 2013, 9:11 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/content/ui/composer.xul » ('j') | chrome/content/ui/sendReport.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/content/ui/composer.js
===================================================================
--- a/chrome/content/ui/composer.js
+++ b/chrome/content/ui/composer.js
@@ -319,25 +319,23 @@ function updatePatternSelection()
{
return RegExpFilter.fromText(filter + "$" + item.typeDescr).matches(item.location, item.typeDescr, item.docDomain, item.thirdParty);
}
let anchorStartCheckbox = E("anchorStart");
if (!/^\*/.test(pattern) && testFilter("||" + pattern))
{
disableElement(anchorStartCheckbox, false, "checked", false);
- anchorStartCheckbox.setAttribute("label", anchorStartCheckbox.getAttribute("labelFlexible"));
- anchorStartCheckbox.accessKey = anchorStartCheckbox.getAttribute("accesskeyFlexible");
+ [anchorStartCheckbox.label, anchorStartCheckbox.accessKey] = Utils.splitLabel(anchorStartCheckbox.getAttribute("labelFlexible"));
anchorStartCheckbox.flexibleAnchor = true;
}
else
{
disableElement(anchorStartCheckbox, /^\*/.test(pattern) || !testFilter("|" + pattern), "checked", false);
- anchorStartCheckbox.setAttribute("label", anchorStartCheckbox.getAttribute("labelRegular"));
- anchorStartCheckbox.accessKey = anchorStartCheckbox.getAttribute("accesskeyRegular");
+ [anchorStartCheckbox.label, anchorStartCheckbox.accessKey] = Utils.splitLabel(anchorStartCheckbox.getAttribute("labelRegular"));
anchorStartCheckbox.flexibleAnchor = false;
}
disableElement(E("anchorEnd"), /[\*\^]$/.test(pattern) || !testFilter(pattern + "|"), "checked", false);
updateFilter();
setAdvancedMode(document.documentElement.getAttribute("advancedMode") == "true");
}
« no previous file with comments | « no previous file | chrome/content/ui/composer.xul » ('j') | chrome/content/ui/sendReport.js » ('J')

Powered by Google App Engine
This is Rietveld