Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Delta Between Two Patch Sets: chrome/content/ui/firstRun.html

Issue 11039060: first run page redesign (Closed)
Left Patch Set: codereview updates Created Aug. 27, 2013, 1:20 p.m.
Right Patch Set: improve after wladimirs code review Created Oct. 4, 2013, 4:50 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « build.py ('k') | chrome/content/ui/firstRun.js » ('j') | chrome/content/ui/firstRun.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <!-- 2 <!--
3 - This file is part of Adblock Plus <http://adblockplus.org/>, 3 - This file is part of Adblock Plus <http://adblockplus.org/>,
4 - Copyright (C) 2006-2013 Eyeo GmbH 4 - Copyright (C) 2006-2013 Eyeo GmbH
5 - 5 -
6 - Adblock Plus is free software: you can redistribute it and/or modify 6 - Adblock Plus is free software: you can redistribute it and/or modify
7 - it under the terms of the GNU General Public License version 3 as 7 - it under the terms of the GNU General Public License version 3 as
8 - published by the Free Software Foundation. 8 - published by the Free Software Foundation.
9 - 9 -
10 - Adblock Plus is distributed in the hope that it will be useful, 10 - Adblock Plus is distributed in the hope that it will be useful,
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 <li> 52 <li>
53 <div class="feature-social-image"></div> 53 <div class="feature-social-image"></div>
54 <h4 class="i18n_firstRun_feature_social"></h4> 54 <h4 class="i18n_firstRun_feature_social"></h4>
55 </li> 55 </li>
56 <li> 56 <li>
57 <div class="feature-tracking-image"></div> 57 <div class="feature-tracking-image"></div>
58 <h4 class="i18n_firstRun_feature_tracking"></h4> 58 <h4 class="i18n_firstRun_feature_tracking"></h4>
59 </li> 59 </li>
60 </ul> 60 </ul>
61 61
62 <div id="can-do-more-expanded" class="hide fade"> 62 <div id="can-do-more-expanded">
63 <ul id="features"> 63 <ul id="features">
64 <li id="feature-malware" class="feature"> 64 <li id="feature-malware" class="feature">
65 <div class="feature-image feature-malware-image"></div> 65 <div class="feature-image feature-malware-image"></div>
66 <div class="feature-description"> 66 <div class="feature-description">
67 <div class="feature-description-textblock"> 67 <div class="feature-description-textblock">
68 <h3 class="i18n_firstRun_feature_malware feature-title"></h3> 68 <h3 class="i18n_firstRun_feature_malware feature-title"></h3>
69 <span class="i18n_firstRun_feature_malware_description"></span> 69 <span class="i18n_firstRun_feature_malware_description"></span>
70 </div> 70 </div>
71 <div id="toggle-malware" class="toggle"> 71 <div id="toggle-malware" class="toggle">
72 <div class="i18n_firstRun_toggle_on toggle-on"></div> 72 <div class="i18n_firstRun_toggle_on toggle-on"></div>
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
124 124
125 <section id="share"> 125 <section id="share">
126 <h2 id="share-headline" class="i18n_firstRun_share_headline"></h2> 126 <h2 id="share-headline" class="i18n_firstRun_share_headline"></h2>
127 127
128 <div id="donate-block"> 128 <div id="donate-block">
129 <a id="donate" class="i18n_firstRun_donate" target="_blank"></a> 129 <a id="donate" class="i18n_firstRun_donate" target="_blank"></a>
130 <span id="donate-label" class="i18n_firstRun_donate_label"></span> 130 <span id="donate-label" class="i18n_firstRun_donate_label"></span>
131 </div> 131 </div>
132 132
133 <div id="share-block"> 133 <div id="share-block">
134 <div id="share-buttons"> 134 <div id="share-general" class="share-buttons">
135 <a id="share-facebook" href="https://www.facebook.com/adblockplus" tar get="_blank" data-script="https://facebook.com/plugins/like.php?"> 135 <a id="share-facebook" href="https://www.facebook.com/adblockplus" tar get="_blank" data-script="https://facebook.com/plugins/like.php?">
136 </a> 136 </a>
137 <a id="share-twitter" href="https://twitter.com/adblockplus" target="_ blank" data-script="https://platform.twitter.com/widgets.js"> 137 <a id="share-twitter" href="https://twitter.com/adblockplus" target="_ blank" data-script="https://platform.twitter.com/widgets.js">
138 </a> 138 </a>
139 <a id="share-gplus" href="https://www.google.com/+AdblockPlus" target= "_blank" data-script="https://apis.google.com/js/plusone.js"> 139 <a id="share-gplus" href="https://www.google.com/+AdblockPlus" target= "_blank" data-script="https://apis.google.com/js/plusone.js">
140 </a> 140 </a>
141 </div> 141 </div>
142
143 <!-- Chinese social networks -->
144 <div id="share-chinese" class="share-buttons">
145 <a id="share-renren" href="http://www.renren.com/601651969" target="_b lank">
146 </a>
147 <a id="share-weibo" href="http://e.weibo.com/adblockplus/" target="_bl ank">
148 </a>
149 </div>
142 <span class="i18n_firstRun_share"></span> 150 <span class="i18n_firstRun_share"></span>
143 </div> 151 </div>
152
144 </section> 153 </section>
145 154
146 <footer> 155 <footer>
147 <a id="contributors">Contributor Credits</a> 156 <a id="contributors" class="i18n_firstRun_contributor_credits"></a>
Wladimir Palant 2013/10/02 13:21:39 This string should be localized.
Wladimir Palant 2013/10/02 13:25:43 Never mind, this is apparently already addressed.
148 </footer> 157 </footer>
149 158
150 159
151 <div id="glass-pane"> 160 <div id="glass-pane">
152 <iframe id="share-popup" scrolling="no"></iframe> 161 <iframe id="share-popup" scrolling="no"></iframe>
153 </div> 162 </div>
154 </body> 163 </body>
155 </html> 164 </html>
LEFTRIGHT
« build.py ('k') | chrome/content/ui/firstRun.js » ('j') | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
This is Rietveld