Use XMLHttpRequest.status instead of nsIHttpChannel.responseStatus(same value, better cross-browse…

lib/downloader.js

Index: lib/downloader.js
===================================================================
--- a/lib/downloader.js
+++ b/lib/downloader.js
@@ -213,20 +213,20 @@ Downloader.prototype =
     let errorCallback = function errorCallback(error)
     {
       let channelStatus = -1;
       try
       {
         channelStatus = request.channel.status;
       } catch (e) {}
 
-      let responseStatus = "";
+      let responseStatus = -1;
       try
       {
-        responseStatus = request.channel.QueryInterface(Ci.nsIHttpChannel).responseStatus;
+        responseStatus = request.status;

[Thomas Greiner, 2013/07/31 12:34:45]

You don't need a try/catch here anymore. You can simply do
let responseStatus = request.status || -1;

[Wladimir Palant, 2013/07/31 13:31:26]

I verified that the Mozilla implementation indeed doesn't throw exceptions, I
assume that other browsers don't do it either. Left out the || -1 part however -
if request.status is 0 then that's what we should report. -1 was a placeholder
for "cannot retrieve".

       } catch (e) {}
 
       Cu.reportError("Adblock Plus: Downloading URL " + downloadable.url + " failed (" + error + ")\n" +
                      "Download address: " + downloadURL + "\n" +
                      "Channel status: " + channelStatus + "\n" +
                      "Server response: " + responseStatus);
 
       if (this.onDownloadError)