Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: background.js

Issue 29317001: Relocated icon and redesigned icon popup (Closed)
Patch Set: Created Nov. 7, 2013, 5:44 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « _locales/en_US/messages.json ('k') | icons/abp-19.png » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: background.js
===================================================================
--- a/background.js
+++ b/background.js
@@ -123,16 +123,16 @@
if (activeNotification)
startIconAnimation(tab, iconFilename);
else
- chrome.pageAction.setIcon({tabId: tab.id, path: iconFilename});
+ chrome.browserAction.setIcon({tabId: tab.id, path: iconFilename});
// Only show icon for pages we can influence (http: and https:)
if(/^https?:/.test(tab.url))
{
- chrome.pageAction.setTitle({tabId: tab.id, title: "Adblock Plus"});
+ chrome.browserAction.setTitle({tabId: tab.id, title: "Adblock Plus"});
if ("shouldShowIcon" in localStorage && localStorage["shouldShowIcon"] == "false")
- chrome.pageAction.hide(tab.id);
+ chrome.browserAction.hide(tab.id);
else
- chrome.pageAction.show(tab.id);
+ chrome.browserAction.show(tab.id);
// Set context menu status according to whether current tab has whitelisted domain
if (excluded)
@@ -543,7 +543,7 @@
context.globalAlpha = opacity;
context.drawImage(notificationIcon, 0, 0);
var imageData = context.getImageData(0, 0, canvas.width, canvas.height);
- chrome.pageAction.setIcon({tabId: tab.id, imageData: imageData});
+ chrome.browserAction.setIcon({tabId: tab.id, imageData: imageData});
var interval;
currentFrame++;
« no previous file with comments | « _locales/en_US/messages.json ('k') | icons/abp-19.png » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld