Unified Diff: background.js
Issue 29317001:
Relocated icon and redesigned icon popup (Closed)
Patch Set: Applied Sebastian's suggestions and updated strings
Created Nov. 26, 2013, 4:18 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« _locales/en_US/messages.json ('k')
|
chrome/background.js » ('j')
|
chrome/background.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: background.js |
| =================================================================== |
| --- a/background.js |
| +++ b/background.js |
| @@ -128,15 +128,15 @@ |
| iconFilename = excluded ? "icons/abp-19-whitelisted.png" : "icons/abp-19.png"; |
| } |
| - tab.pageAction.setIcon(iconFilename); |
| - tab.pageAction.setTitle(ext.i18n.getMessage("name")); |
| + tab.browserAction.setIcon(iconFilename); |
| + tab.browserAction.setTitle(ext.i18n.getMessage("name")); |
| iconAnimation.registerTab(tab, iconFilename); |
| if (localStorage.shouldShowIcon == "false") |
| - tab.pageAction.hide(); |
| + tab.browserAction.hide(); |
| else |
| - tab.pageAction.show(); |
| + tab.browserAction.show(); |
| if (require("info").platform == "chromium") // TODO: Implement context menus for Safari |
| // Set context menu status according to whether current tab has whitelisted domain |
« no previous file with comments
|
« _locales/en_US/messages.json ('k')
|
chrome/background.js » ('j')
|
chrome/background.js » ('J')
