messageResponder.js - Issue 29322723: Issue 2805 - Only require filterValidation module where necessary

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: messageResponder.js

Issue 29322723: Issue 2805 - Only require filterValidation module where necessary (Closed)

Patch Set: Created July 20, 2015, 7:48 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: messageResponder.js

===================================================================

--- a/messageResponder.js

+++ b/messageResponder.js

@@ -30,7 +30,6 @@

var Filter = filterClasses.Filter;

var BlockingFilter = filterClasses.BlockingFilter;

var Synchronizer = require("synchronizer").Synchronizer;

- var filterValidation = require("filterValidation");

var subscriptionClasses = require("subscriptionClasses");

var Subscription = subscriptionClasses.Subscription;

@@ -183,7 +182,7 @@

break;

case "filters.add":

var filter = Filter.fromText(message.text);

- var result = filterValidation.parseFilter(message.text);

+ var result = require("filterValidation").parseFilter(message.text);

if (result.error)

sendMessage("app", "error", [result.error.toString()], sender.page);

else if (result.filter)

@@ -205,7 +204,7 @@

callback(subscription.filters.map(convertFilter));

break;

case "filters.importRaw":

- var result = filterValidation.parseFilters(message.text);

+ var result = require("filterValidation").parseFilters(message.text);

var errors = [];

for (var i = 0; i < result.errors.length; i++)

{

« no previous file with comments | « no previous file | no next file » | no next file with comments »