Issue #1234, #2058 - Rewrite log facility, improving thread implementation

adblockplus.gyp

 {
   'includes': [
     'defaults.gypi',
     'common/common.gypi',
   ],
 
   'variables': {
     'build_type%': 'devbuild',
     'build_version%': '',
   },
@@ skipping 103 matching lines @@
       'src/plugin/ActiveQueue.h',
       'src/plugin/AdblockPlus.def',
       'src/plugin/AdblockPlus.idl',
       'src/plugin/AdblockPlus.rc',
       'src/plugin/AdblockPlus.rgs',
       'src/plugin/AdblockPlusClient.cpp',
       'src/plugin/AdblockPlusClient.h',
       'src/plugin/AdblockPlusDomTraverser.cpp',
       'src/plugin/AdblockPlusDomTraverser.h',
       'src/plugin/AdblockPlusGuids.h',
-      'src/plugin/ATL_Deprecate.cpp',
       'src/plugin/ATL_Deprecate.h',
       'src/plugin/Config.h',
+      'src/plugin/Instances.h',
       'src/plugin/NotificationMessage.cpp',
       'src/plugin/NotificationMessage.h',
       'src/plugin/Placeholder.h',
       'src/plugin/Plugin.cpp',
       'src/plugin/Plugin.h',
       'src/plugin/PluginClass.cpp',
       'src/plugin/PluginClass.h',
       'src/plugin/PluginClientFactory.cpp',
       'src/plugin/PluginClientFactory.h',
       'src/plugin/PluginDebug.cpp',
@@ skipping 90 matching lines @@
     'target_name': 'tests_plugin',
     'type': 'executable',
     'dependencies': [
       'shared',
       'libadblockplus/libadblockplus.gyp:libadblockplus',
       'libadblockplus/third_party/googletest.gyp:googletest_main',
     ],
     'sources': [
       'src/plugin/PluginDebug.cpp',
       'test/plugin/DebugTest.cpp',
+      'src/plugin/Instances.h',
+      'test/plugin/InstancesTest.cpp',
       'src/plugin/PluginUserSettings.cpp',
       'src/plugin/PluginUserSettings.h',
       'test/plugin/UserSettingsTest.cpp',
       'src/plugin/PluginUtil.h',
       'test/plugin/UtilTest.cpp',
       #
       # required only for linking
       #
       'src/plugin/AdblockPlusClient.cpp',
       'src/plugin/AdblockPlusDomTraverser.cpp',
-      'src/plugin/ATL_Deprecate.cpp',
       'src/plugin/NotificationMessage.cpp',
       'src/plugin/Plugin.cpp',
       'src/plugin/PluginClientFactory.cpp',
       'src/plugin/PluginClass.cpp',
       'src/plugin/PluginFilter.cpp',
       'src/plugin/PluginMimeFilterClient.cpp',
       'src/plugin/PluginMutex.cpp',
       'src/plugin/PluginSettings.cpp',
       'src/plugin/PluginSystem.cpp',
       'src/plugin/PluginTabBase.cpp',
@@ skipping 39 matching lines @@
       'src/plugin/ActiveQueue.h',
       'src/plugin/Placeholder.h',
       'test/plugin/ActiveQueueTest.cpp',
       'test/plugin/PlaceholderTest.cpp',
     ],
     'defines': [
     ],
     'link_settings': {
       'libraries': [],
     },
     #'msbuild_toolset': 'v140',

[Oleksandr, 2016/01/28 10:15:33]

Nit: Is this some test code commented out? Looks confusing here, IMO.

[Eric, 2016/02/04 21:01:43]

Not so much test code as needed during development. Getting a move-only class to
work right meant temporarily upgrading the compiler to support "= delete" on
copy constructors.

Perhaps more importantly, I'm not sure we need to retain a second unit test
project here. I needed it so that I could use a different compiler (which was,
for reasons I've forgotten, problematic on the first unit test project). It does
have some utility in segregating out the thread-heavy unit tests from the rest,
since when these unit tests crash, they crash hard.

     'msvs_settings': {
       'VCLinkerTool': {
         'SubSystem': '1', # Console
         'EntryPointSymbol': 'mainCRTStartup',
       },
     },
   },
   
   ]
 }