Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/plugin/PluginTabBase.h

Issue 29323611: Issue #1234, #2058 - Rewrite log facility, improving thread implementation
Patch Set: rebase to current tip Created Jan. 5, 2016, 2:52 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/plugin/PluginTabBase.h
===================================================================
--- a/src/plugin/PluginTabBase.h
+++ b/src/plugin/PluginTabBase.h
@@ -34,15 +34,10 @@
std::wstring m_documentDomain;
std::wstring m_documentUrl;
CPluginUserSettings m_pluginUserSettings;
- bool m_isActivated;
-
- std::thread m_thread;
- std::atomic<bool> m_continueThreadRunning;
CPluginDomTraverser* m_traverser;
public:
CPluginFilter m_filter;
private:
- void ThreadProc();
CComAutoCriticalSection m_criticalSectionCache;
std::set<std::wstring> m_cacheFrames;
std::wstring m_cacheDomain;
@@ -55,12 +50,9 @@
std::wstring GetDocumentDomain();
void SetDocumentUrl(const std::wstring& url);
std::wstring GetDocumentUrl();
- virtual void OnActivate();
- virtual void OnUpdate();
virtual void OnNavigate(const std::wstring& url);
virtual void OnDownloadComplete(IWebBrowser2* browser);
virtual void OnDocumentComplete(IWebBrowser2* browser, const std::wstring& url, bool isDocumentBrowser);
- static DWORD WINAPI TabThreadProc(LPVOID pParam);
void CacheFrame(const std::wstring& url);
bool IsFrameCached(const std::wstring& url);
void ClearFrameCache(const std::wstring& domain=L"");

Powered by Google App Engine
This is Rietveld