Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Side by Side Diff: mozharness/abb/__init__.py
Issue
29327949
:
Issue 3047 - Change default search engines (Closed)
Patch Set: More search engines for China.
Created Sept. 15, 2015, 5:45 p.m.
Left:
Base
Patch Set 1: None
Patch Set 2: Now really writing region.properties to region.properties.
Patch Set 3: Added a missing colon to a log message.
Patch Set 4: Limit search.order entries to 3.
Patch Set 5: Re-added Google/Yahoo/Amazon for China.
Patch Set 6: More search engines for China.
Patch Set 7: Removed a comma.
Patch Set 8: regex enhancement, code duplication reduction.
Patch Set 9: Beautification
Patch Set 10: trim()/strip()
Patch Set 11: Names and stuff
Patch Set 12: Brackets
Patch Set 13: Removed overly complicated currying, replaced with class
Patch Set 14: That trim() was persistent, removed _again_.
Patch Set 15: Fixed even more review issues
Right:
Patch Set 1: None
Patch Set 2: Now really writing region.properties to region.properties.
Patch Set 3: Added a missing colon to a log message.
Patch Set 4: Limit search.order entries to 3.
Patch Set 5: Re-added Google/Yahoo/Amazon for China.
Patch Set 6: More search engines for China.
Patch Set 7: Removed a comma.
Patch Set 8: regex enhancement, code duplication reduction.
Patch Set 9: Beautification
Patch Set 10: trim()/strip()
Patch Set 11: Names and stuff
Patch Set 12: Brackets
Patch Set 13: Removed overly complicated currying, replaced with class
Patch Set 14: That trim() was persistent, removed _again_.
Patch Set 15: Fixed even more review issues
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
mozharness/abb/__init__.py
mozharness/abb/abb_transform_locales.py
mozharness/mozilla/l10n/multi_locale_build.py
View unified diff
|
Download patch
« no previous file with comments
|
« no previous file
|
mozharness/abb/abb_transform_locales.py »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
(Empty)
OLD
NEW
« no previous file with comments
|
« no previous file
|
mozharness/abb/abb_transform_locales.py »
('j') |
no next file with comments »
Edit Message
Issue 29327949: Issue 3047 - Change default search engines (Closed)
Created Sept. 15, 2015, 4:37 p.m. by René Jeschke
Modified Sept. 24, 2015, 8:25 a.m.
Reviewers: Felix Dahlke
Base URL:
Comments: 42
This is Rietveld