Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: templates/sitekey_frame.tmpl

Issue 29328600: Issue 3122 - Add sitekey frame files ready for sitekey testcases (Closed)
Left Patch Set: Deleted some erroneous whitespace Created Sept. 24, 2015, 4:58 p.m.
Right Patch Set: Attempt to make frame URL logic clearer Created Oct. 13, 2015, 11:28 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « templates/frame.tmpl ('k') | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 {% extends "frame.tmpl" %} 1 {% extends "frame.tmpl" %}
saroyanm 2015/10/13 12:24:44 "TemplateNotFound: frame.tmpl" maybe -> {% extends
kzar 2015/10/15 15:06:21 I'm not able to reproduce that problem, when exact
saroyanm 2015/10/15 15:38:16 Assigne this template to some page `template=sitek
kzar 2015/10/15 16:19:12 Ah right I see, well it's designed to be rendered
saroyanm 2015/10/15 16:23:23 But if you use -> {% extends "templates/frame" %}
kzar 2015/10/15 16:28:51 So this template is designed to be rendered by sit
2 2
3 {% block body %} 3 {% block body %}
4 <script type="text/javascript"> 4 <script type="text/javascript">
5 function transform_url(href, hash) 5 function frame_url(parent_location)
6 { 6 {
7 return hash.substring(1); 7 return parent_location.hash.substring(1);
8 } 8 }
9 </script> 9 </script>
10 {% endblock %} 10 {% endblock %}
LEFTRIGHT

Powered by Google App Engine
This is Rietveld