Issue 3208 - Improve the approach used to detect pop-up URL

lib/contentPolicy.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 465 matching lines @@
 
         let uri = additional || Utils.makeURI(subject.location.href);
         if (!Policy.processNode(subject.opener, subject.opener.document, Policy.type.POPUP, uri, false))
         {
           subject.stop();
           Utils.runAsync(() => subject.close());
         }
         else if (uri.spec == "about:blank")
         {
           // An about:blank pop-up most likely means that a load will be
-          // initiated synchronously. Set a flag for our "http-on-opening-request"
-          // handler.
-          this.expectingPopupLoad = true;
+          // initiated asynchronously. Wait for that.
           Utils.runAsync(function()
           {
-            this.expectingPopupLoad = false;
+            let channel = subject.QueryInterface(Ci.nsIInterfaceRequestor)
+                                 .getInterface(Ci.nsIDocShell)
+                                 .QueryInterface(Ci.nsIDocumentLoader)
+                                 .documentChannel;
+            if (channel)
+              this.observe(subject, topic, data, channel.URI.spec);
           });
         }
         break;
       }
       case "http-on-opening-request":
       case "http-on-modify-request":
       {
         if (!(subject instanceof Ci.nsIHttpChannel))
           return;
 
         if (this.previousRequest && subject.URI == this.previousRequest[0] &&
             subject instanceof Ci.nsIWritablePropertyBag)
         {
           // We just handled a content policy call for this request - associate
           // the data with the channel so that we can find it in case of a redirect.
           subject.setProperty("abpRequestType", this.previousRequest[1]);
           this.previousRequest = null;
         }
-
-        if (this.expectingPopupLoad)
-        {
-          let wnd = Utils.getRequestWindow(subject);
-          if (wnd && wnd.opener && wnd.location.href == "about:blank")
-          {
-            this.observe(wnd, "content-document-global-created", null, subject.URI);
-            if (subject instanceof Ci.nsIWritablePropertyBag)
-              subject.setProperty("abpRequestType", Policy.type.POPUP);
-          }
-        }
-
         break;
       }
     }
   },
 
   //
   // nsIChannelEventSink interface implementation
   //
 
   asyncOnChannelRedirect: function(oldChannel, newChannel, flags, callback)
@@ skipping 253 matching lines @@
   if (!wnd || wnd.closed)
     return;
 
   if (entry.type == Policy.type.OBJECT)
   {
     node.removeEventListener("mouseover", objectMouseEventHander, true);
     node.removeEventListener("mouseout", objectMouseEventHander, true);
   }
   Policy.processNode(wnd, node, entry.type, Utils.makeURI(entry.location), true);
 }