Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/ui.js

Issue 29329479: Issue 3222 - Get rid of RequestEntry.typeDescr property (Closed)
Patch Set: Created Oct. 29, 2015, 1:57 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/requestNotifier.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/ui.js
===================================================================
--- a/lib/ui.js
+++ b/lib/ui.js
@@ -1607,17 +1607,17 @@ let UI = exports.UI =
if (!target)
return;
let window = popup.ownerDocument.defaultView;
let menuItems = [];
let addMenuItem = function([node, nodeData])
{
- let type = nodeData.typeDescr.toLowerCase();
+ let type = nodeData.type.toLowerCase();
if (type == "background")
{
type = "image";
node = null;
}
let label = this.overlay.attributes[type + "contextlabel"];
if (!label)
@@ -1633,17 +1633,17 @@ let UI = exports.UI =
}.bind(this);
// Look up data that we have for the node
let data = RequestNotifier.getDataForNode(target);
let hadImage = false;
if (data && !data[1].filter)
{
addMenuItem(data);
- hadImage = (data[1].typeDescr == "IMAGE");
+ hadImage = (data[1].type == "IMAGE");
}
// Look for frame data
let wnd = Utils.getWindow(target);
if (wnd.frameElement)
{
let data = RequestNotifier.getDataForNode(wnd.frameElement, true);
if (data && !data[1].filter)
« no previous file with comments | « lib/requestNotifier.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld