Issue 3208 - Consider private browsing in contentPolicy module rather than filterStorage

lib/filterStorage.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 305 matching lines @@
       return;
 
     subscription.filters.splice(oldPosition, 1);
     subscription.filters.splice(newPosition, 0, filter);
     FilterNotifier.triggerListeners("filter.moved", filter, subscription, oldPosition, newPosition);
   },
 
   /**
    * Increases the hit count for a filter by one
    * @param {Filter} filter
-   * @param {Window} window  Window that the match originated in (required
-   *                         to recognize private browsing mode)
    */
-  increaseHitCount: function(filter, wnd)
+  increaseHitCount: function(filter)
   {
-    if (!Prefs.savestats || PrivateBrowsing.enabledForWindow(wnd) ||
-        PrivateBrowsing.enabled || !(filter instanceof ActiveFilter))
-    {
+    if (!Prefs.savestats || !(filter instanceof ActiveFilter))
       return;
-    }
 
     filter.hitCount++;
     filter.lastHit = Date.now();
   },
 
   /**
    * Resets hit count for some filters
    * @param {Filter[]} filters  filters to be reset, if null all filters will be reset
    */
   resetHitCounts: function(filters)
@@ skipping 342 matching lines @@
 
   for (let filter of subscription.filters)
   {
     let i = filter.subscriptions.indexOf(subscription);
     if (i >= 0)
       filter.subscriptions.splice(i, 1);
   }
 }
 
 /**
- * Observer listening to private browsing mode changes.
- * @class
- */
-let PrivateBrowsing = exports.PrivateBrowsing =
-{
-  /**
-   * Will be set to true when the private browsing mode is switched on globally.
-   * @type Boolean
-   */
-  enabled: false,
-
-  /**
-   * Checks whether private browsing is enabled for a particular window.
-   */
-  enabledForWindow: function(/**Window*/ wnd) /**Boolean*/
-  {
-    try
-    {
-      return wnd.QueryInterface(Ci.nsIInterfaceRequestor)
-                .getInterface(Ci.nsILoadContext)
-                .usePrivateBrowsing;
-    }
-    catch (e)
-    {
-      // Gecko 19 and below will throw NS_NOINTERFACE, this is expected
-      if (e.result != Cr.NS_NOINTERFACE)
-        Cu.reportError(e);
-      return false;
-    }
-  },
-
-  init: function()
-  {
-    if ("@mozilla.org/privatebrowsing;1" in Cc)
-    {
-      try
-      {
-        this.enabled = Cc["@mozilla.org/privatebrowsing;1"].getService(Ci.nsIPrivateBrowsingService).privateBrowsingEnabled;
-        Services.obs.addObserver(this, "private-browsing", true);
-        onShutdown.add(function()
-        {
-          Services.obs.removeObserver(this, "private-browsing");
-        }.bind(this));
-      }
-      catch(e)
-      {
-        Cu.reportError(e);
-      }
-    }
-  },
-
-  observe: function(subject, topic, data)
-  {
-    if (topic == "private-browsing")
-    {
-      if (data == "enter")
-        this.enabled = true;
-      else if (data == "exit")
-        this.enabled = false;
-    }
-  },
-
-  QueryInterface: XPCOMUtils.generateQI([Ci.nsISupportsWeakReference, Ci.nsIObserver])
-};
-PrivateBrowsing.init();
-
-/**
  * IO.readFromFile() listener to parse filter data.
  * @constructor
  */
 function INIParser()
 {
   this.fileProperties = this.curObj = {};
   this.subscriptions = [];
   this.knownFilters = Object.create(null);
   this.knownSubscriptions = Object.create(null);
 }
@@ skipping 88 matching lines @@
       Subscription.knownSubscriptions = origKnownSubscriptions;
     }
 
     // Allow events to be processed every now and then.
     // Note: IO.readFromFile() will deal with the potential reentrance here.
     this.linesProcessed++;
     if (this.linesProcessed % 1000 == 0)
       Utils.yield();
   }
 };