hiera/roles/telemetryserver.yaml - Issue 29329669: Issue 3261 - Introduce module adblockplus::telemetry

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: hiera/roles/telemetryserver.yaml

Issue 29329669: Issue 3261 - Introduce module adblockplus::telemetry (Closed)

Left Patch Set: Created Nov. 3, 2015, 4:46 a.m.

Right Patch Set: Issue 3261 - Rename /submit/{filter-hit-statistics => adblockplus} Created Nov. 13, 2015, 9:29 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 classes:	1 classes:

2 adblockplus::telemetry:	2 adblockplus::telemetry:

3 domain: "telemetry.adblockplus.org"	3 domain: "telemetry.adblockplus.org"

4	4

5 adblockplus::telemetry::endpoints:	5 adblockplus::telemetry::endpoints:

6 filter_hit_statistics:	6 adblockplus:

7 location: /submit/filter-hit-statistics	7 location: /submit/adblockplus
mathias 2015/11/03 10:34:53 Note that this location conflicts with the one ini Note that this location conflicts with the one initially suggested (/submit) which, however, does not make much sense in the context of an explicit telemetry.adblockplus.org domain which may host multiple endpoints - alongside some other stuff - in the future. To name a particular example: It could make sense to move the Adblock Browser feedback endpoint to the telemetry.adblockplus.org domain as well, i.e. /submit/adblock-browser-feedback. The current endpoint at adblockbrowser.org could become a forwarding proxy until it does not receive requests any more. Felix Dahlke 2015/11/10 15:29:14 Well, feedback and telemetry are quite different t Show quoted text On 2015/11/03 10:34:53, mathias wrote: > > Note that this location conflicts with the one initially suggested (/submit) > which, however, does not make much sense in the context of an explicit > http://telemetry.adblockplus.org domain which may host multiple endpoints - alongside > some other stuff - in the future. > > To name a particular example: It could make sense to move the Adblock Browser > feedback endpoint to the http://telemetry.adblockplus.org domain as well, i.e. > /submit/adblock-browser-feedback. The current endpoint at http://adblockbrowser.org > could become a forwarding proxy until it does not receive requests any more. Well, feedback and telemetry are quite different things, I'd prefer to keep this separated. If we were to combine it I think we would need a more generic umbrella, e.g. "submit.adblockplus.org". (IIRC, Mozilla has "api.mozilla.org" for a similar purpose.) Also: How I remember the discussion, we would send _all_ telemetry data within that one JSON, i.e. "/submit" seems fine. But let's double check that that's really how we discussed it should work.
8	8

LEFT	RIGHT