Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Side by Side Diff: static/img/background-blue.png
Issue
29329984
:
Issue 3257 - Create uninstallation page in adblockplus.org (Closed)
Patch Set: Addressed Thomas initiall comments
Created Nov. 12, 2015, 3:43 p.m.
Left:
Base
Patch Set 1: None
Patch Set 2: Addressed Thomas initiall comments
Patch Set 3: Rename logo to make it consistent
Patch Set 4: Addressed Dave comments
Patch Set 5: Removed the shuffling filter
Patch Set 6: Rename jinja files to markdown
Patch Set 7: Fix old jinja files compatibility with markdown and implement noscript
Patch Set 8: Removed noscript notification
Patch Set 9: renamed merkurial files to template
Patch Set 10: Removed section from template
Patch Set 11: Fix editor readability, use for loop to randomly generate the list
Patch Set 12: rename template files again back to markdown
Patch Set 13: move include files content to markdown
Patch Set 14: Addressed Dave comments
Patch Set 15: Addressed Thomas comments
Patch Set 16: Switched to old implementation of shuffling using while
Patch Set 17: renamed .md file back to .tmpl
Patch Set 18: Generate reasons in HTML then shuffle them
Patch Set 19: Addressed Thomas comments
Patch Set 20: Convert to array instead of cloning
Right:
Patch Set 1: None
Patch Set 2: Addressed Thomas initiall comments
Patch Set 3: Rename logo to make it consistent
Patch Set 4: Addressed Dave comments
Patch Set 5: Removed the shuffling filter
Patch Set 6: Rename jinja files to markdown
Patch Set 7: Fix old jinja files compatibility with markdown and implement noscript
Patch Set 8: Removed noscript notification
Patch Set 9: renamed merkurial files to template
Patch Set 10: Removed section from template
Patch Set 11: Fix editor readability, use for loop to randomly generate the list
Patch Set 12: rename template files again back to markdown
Patch Set 13: move include files content to markdown
Patch Set 14: Addressed Dave comments
Patch Set 15: Addressed Thomas comments
Patch Set 16: Switched to old implementation of shuffling using while
Patch Set 17: renamed .md file back to .tmpl
Patch Set 18: Generate reasons in HTML then shuffle them
Patch Set 19: Addressed Thomas comments
Patch Set 20: Convert to array instead of cloning
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
filters/shuffle.py
pages/uninstall-abp.tmpl
pages/uninstall-abp-submit.tmpl
static/css/simple.css
static/fonts/SourceSansPro-Light.woff
static/fonts/SourceSansPro-Regular.woff
static/fonts/SourceSansPro-Semibold.woff
static/img/adblockplus_new_100.png
static/img/background-blue.png
static/img/background-dark.png
templates/simple.tmpl
View unified diff
|
Download patch
« no previous file with comments
|
« static/img/adblockplus_new_100.png
('k') |
static/img/background-dark.png »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
OLD
NEW
« no previous file with comments
|
« static/img/adblockplus_new_100.png
('k') |
static/img/background-dark.png »
('j') |
no next file with comments »
Edit Message
Issue 29329984: Issue 3257 - Create uninstallation page in adblockplus.org (Closed)
Created Nov. 11, 2015, 5:43 p.m. by saroyanm
Modified Dec. 3, 2015, 2:18 p.m.
Reviewers Thomas Greiner, kzar
Base URL:
Comments: 131
This is Rietveld