Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: pages/uninstall-abp.tmpl

Issue 29329984: Issue 3257 - Create uninstallation page in adblockplus.org (Closed)
Left Patch Set: Addressed Thomas comments Created Dec. 3, 2015, 1:04 p.m.
Right Patch Set: Convert to array instead of cloning Created Dec. 3, 2015, 1:55 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | pages/uninstall-abp-submit.md » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 title=Adblock Plus has been uninstalled 1 title=Adblock Plus has been uninstalled
2 template=simple 2 template=simple
3 3
4 {% set reasons = [ 4 {% set reasons = [
5 ("1v0", "reason-not-installed", "I didn't install Adblock Plus."), 5 ("1v0", "reason-not-installed", "I didn't install Adblock Plus."),
6 ("2v0", "reason-slowing-down", "Adblock Plus slowed down my browser."), 6 ("2v0", "reason-slowing-down", "Adblock Plus slowed down my browser."),
7 ("3v0", "reason-acceptable-ads", "I don't like the Acceptable Ads program."), 7 ("3v0", "reason-acceptable-ads", "I don't like the Acceptable Ads program."),
8 ("4v0", "reason-see-ads", "Adblock Plus didn't block all ads."), 8 ("4v0", "reason-see-ads", "Adblock Plus didn't block all ads."),
9 ("5v0", "reason-better-adblocker", "I found better ad blocking software."), 9 ("5v0", "reason-better-adblocker", "I found better ad blocking software."),
10 ("6v0", "reason-break-websites", "Adblock Plus breaks websites that I visit.") 10 ("6v0", "reason-break-websites", "Adblock Plus breaks websites that I visit.")
(...skipping 17 matching lines...) Expand all
28 var paramSplit = param.split("="); 28 var paramSplit = param.split("=");
29 var input = document.createElement("input"); 29 var input = document.createElement("input");
30 input.setAttribute("type", "hidden"); 30 input.setAttribute("type", "hidden");
31 input.setAttribute("name", paramSplit[0]); 31 input.setAttribute("name", paramSplit[0]);
32 input.setAttribute("value", paramSplit[1]); 32 input.setAttribute("value", paramSplit[1]);
33 form.appendChild(input); 33 form.appendChild(input);
34 }); 34 });
35 35
36 // Randomly add reasons 36 // Randomly add reasons
37 var reasonsContainer = document.getElementById("reasons"); 37 var reasonsContainer = document.getElementById("reasons");
38 var reasons = reasonsContainer.cloneNode(true).getElementsByTagName("li"); 38 var reasons = reasonsContainer.getElementsByTagName("li");
39 reasons = Array.prototype.slice.call(reasons);
39 reasonsContainer.innerHTML = ""; 40 reasonsContainer.innerHTML = "";
40 reasons = Array.prototype.slice.call(reasons);
41 while (reasons.length) 41 while (reasons.length)
42 { 42 {
43 var randomIndex = Math.floor(Math.random() * (reasons.length -1)); 43 var randomIndex = Math.floor(Math.random() * (reasons.length -1));
44 var reasonElement = reasons.splice(randomIndex, 1)[0]; 44 var reasonElement = reasons.splice(randomIndex, 1)[0];
45 reasonsContainer.appendChild(reasonElement); 45 reasonsContainer.appendChild(reasonElement);
46 } 46 }
47 47
48 var reasonOtherCheckbox = document.getElementById("reason-other"); 48 var reasonOtherCheckbox = document.getElementById("reason-other");
49 reasonOtherCheckbox.addEventListener("change", function() 49 reasonOtherCheckbox.addEventListener("change", function()
50 { 50 {
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 <textarea id="reason-other-input" class="hidden" name="reasonOther" plac eholder="{{"Please explain why you are uninstalling Adblock Plus"|translate("rea son-other-placeholder", "Textarea placeholder text, appears after selecting 'Oth er, namely...' option")}}"></textarea> 94 <textarea id="reason-other-input" class="hidden" name="reasonOther" plac eholder="{{"Please explain why you are uninstalling Adblock Plus"|translate("rea son-other-placeholder", "Textarea placeholder text, appears after selecting 'Oth er, namely...' option")}}"></textarea>
95 </li> 95 </li>
96 </ul> 96 </ul>
97 <button id="submit-form">{{"Submit"|translate("submit", "Submit button text" )}}</button> 97 <button id="submit-form">{{"Submit"|translate("submit", "Submit button text" )}}</button>
98 <span class="error-label">{{"Please select at least one of the options above "|translate("error-msg", "Error message, is being shown after submission if no i tem selected")}}</span> 98 <span class="error-label">{{"Please select at least one of the options above "|translate("error-msg", "Error message, is being shown after submission if no i tem selected")}}</span>
99 </form> 99 </form>
100 <p class="disclaimer"> 100 <p class="disclaimer">
101 {{"By clicking Submit, you are sending your response to Adblock Plus. Please see our <a href='/privacy'>privacy policy</a>."|translate("disclaimer", "Discla imer below form")}} 101 {{"By clicking Submit, you are sending your response to Adblock Plus. Please see our <a href='/privacy'>privacy policy</a>."|translate("disclaimer", "Discla imer below form")}}
102 </p> 102 </p>
103 </section> 103 </section>
LEFTRIGHT

Powered by Google App Engine
This is Rietveld