Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: chrome/content/ui/filters-backup.js

Issue 29330225: Issue 3327 - Set minVersion correctly when exporting $generichide or $genericblock filters (Closed)
Patch Set: Created Nov. 16, 2015, 2:20 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/content/ui/filters-backup.js
===================================================================
--- a/chrome/content/ui/filters-backup.js
+++ b/chrome/content/ui/filters-backup.js
@@ -308,16 +308,19 @@ var Backup =
continue;
// Skip group headers
if (filter instanceof CommentFilter && this.GROUPTITLE_REGEXP.test(filter.text))
continue;
list.push(filter.text);
if (filter instanceof ElemHideException && Services.vc.compare(minVersion, "2.1") < 0)
minVersion = "2.1";
+
+ if (filter instanceof RegExpFilter && filter.contentType & (RegExpFilter.typeMap.GENERICHIDE | RegExpFilter.typeMap.GENERICBLOCK) && Services.vc.compare(minVersion, "2.6.12") < 0)
+ minVersion = "2.6.12";
}
}
list.unshift("[Adblock Plus " + minVersion + "]");
// Insert checksum. Have to add an empty line to the end of the list to
// account for the trailing newline in the file.
list.push("");
let checksum = Utils.generateChecksum(list);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld