Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: pages/uninstalled.tmpl

Issue 29332615: Issue 3257 - Create uninstallation page in adblockplus.org (use GET http request) (Closed)
Patch Set: Addressed Sebastian comments Created Dec. 14, 2015, 2:47 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | pages/uninstalled-submit.md » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 title=Adblock Plus has been uninstalled 1 title=Adblock Plus has been uninstalled
2 template=simple 2 template=simple
3 3
4 {% set reasons = [ 4 {% set reasons = [
5 ("1v0", "reason-not-installed", "I didn't install Adblock Plus."), 5 ("1v0", "reason-not-installed", "I didn't install Adblock Plus."),
6 ("2v0", "reason-slowing-down", "Adblock Plus slowed down my browser."), 6 ("2v0", "reason-slowing-down", "Adblock Plus slowed down my browser."),
7 ("3v0", "reason-acceptable-ads", "I don't like the Acceptable Ads program."), 7 ("3v0", "reason-acceptable-ads", "I don't like the Acceptable Ads program."),
8 ("4v0", "reason-see-ads", "Adblock Plus didn't block all ads."), 8 ("4v0", "reason-see-ads", "Adblock Plus didn't block all ads."),
9 ("5v0", "reason-better-adblocker", "I found better ad blocking software."), 9 ("5v0", "reason-better-adblocker", "I found better ad blocking software."),
10 ("6v0", "reason-break-websites", "Adblock Plus breaks websites that I visit.") 10 ("6v0", "reason-break-websites", "Adblock Plus breaks websites that I visit.")
(...skipping 10 matching lines...) Expand all
21 21
22 // Create hidden input for GET parameters 22 // Create hidden input for GET parameters
23 window.location.search.substr(1).split("&").forEach(function(param) 23 window.location.search.substr(1).split("&").forEach(function(param)
24 { 24 {
25 if (!/.=./.test(param)) 25 if (!/.=./.test(param))
26 return; 26 return;
27 27
28 var paramSplit = param.split("="); 28 var paramSplit = param.split("=");
29 var input = document.createElement("input"); 29 var input = document.createElement("input");
30 input.setAttribute("type", "hidden"); 30 input.setAttribute("type", "hidden");
31 input.setAttribute("name", paramSplit[0]); 31 input.setAttribute("name", decodeURIComponent(paramSplit[0]));
32 input.setAttribute("value", paramSplit[1]); 32 input.setAttribute("value", decodeURIComponent(paramSplit[1]));
33 form.appendChild(input); 33 form.appendChild(input);
34 }); 34 });
35 35
36 // Randomly add reasons 36 // Randomly add reasons
37 var reasonsContainer = document.getElementById("reasons"); 37 var reasonsContainer = document.getElementById("reasons");
38 var reasons = reasonsContainer.getElementsByTagName("li"); 38 var reasons = reasonsContainer.getElementsByTagName("li");
39 reasons = Array.prototype.slice.call(reasons); 39 reasons = Array.prototype.slice.call(reasons);
40 reasonsContainer.innerHTML = ""; 40 reasonsContainer.innerHTML = "";
41 while (reasons.length) 41 while (reasons.length)
42 { 42 {
43 var randomIndex = Math.floor(Math.random() * (reasons.length -1)); 43 var randomIndex = Math.floor(Math.random() * (reasons.length -1));
44 var reasonElement = reasons.splice(randomIndex, 1)[0]; 44 var reasonElement = reasons.splice(randomIndex, 1)[0];
45 reasonsContainer.appendChild(reasonElement); 45 reasonsContainer.appendChild(reasonElement);
46 } 46 }
47 47
48 var reasonOtherCheckbox = document.getElementById("reason-other"); 48 var reasonOtherCheckbox = document.getElementById("reason-other");
49 var reasonOther = document.getElementById("reason-other-container");
49 reasonOtherCheckbox.addEventListener("change", function() 50 reasonOtherCheckbox.addEventListener("change", function()
50 { 51 {
51 var textArea = document.getElementById("reason-other-input"); 52 reasonOther.classList.toggle("hidden")
Sebastian Noack 2015/12/14 14:51:40 Nit: Missing semicolon
saroyanm 2015/12/14 14:53:19 Ahh, sorry for that, Done.
52 if (textArea.hasAttribute("class")) 53 }, false);
53 textArea.removeAttribute("class") 54
54 else 55 var reasonOtherInput = document.getElementById("reason-other-input");
55 textArea.setAttribute("class", "hidden"); 56 var maxLength = reasonOtherInput.getAttribute("maxlength");
57 var charCounter = document.getElementById("characters-countdown");
58 charCounter.textContent = maxLength;
59 reasonOtherInput.addEventListener("keyup", function()
60 {
61 charCounter.textContent = maxLength - reasonOtherInput.value.length;
56 }, false); 62 }, false);
57 63
58 var submitButton = document.getElementById("submit-form"); 64 var submitButton = document.getElementById("submit-form");
59 submitButton.addEventListener("click", function(event) 65 submitButton.addEventListener("click", function(event)
60 { 66 {
61 if (!document.querySelector("ul input:checked")) 67 if (!document.querySelector("ul input:checked"))
62 { 68 {
63 event.preventDefault(); 69 event.preventDefault();
64 form.setAttribute("class", "error"); 70 form.setAttribute("class", "error");
65 } 71 }
66 else 72 else
67 { 73 {
68 form.submit(); 74 form.submit();
69 } 75 }
70 }, false); 76 }, false);
71 } 77 }
72 document.addEventListener("DOMContentLoaded", init, false); 78 document.addEventListener("DOMContentLoaded", init, false);
73 })(); 79 })();
74 </script> 80 </script>
75 </head> 81 </head>
76 82
77 <section class="highlighted"> 83 <section class="highlighted">
78 <h1>{{"Please select the reason(s) why you uninstalled Adblock Plus:"|translat e("reasons-header", "Form heading")}}</h1> 84 <h1>{{"Please select the reason(s) why you uninstalled Adblock Plus:"|translat e("reasons-header", "Form heading")}}</h1>
79 <form id="reasons-form" action="uninstall-abp-submit" method="post"> 85 <form id="reasons-form" action="uninstalled-submit" method="get">
80 <ul id="reasons"> 86 <ul id="reasons">
81 {%- for reasonId, stringId, value in reasons %} 87 {%- for reasonId, stringId, value in reasons %}
82 <li> 88 <li>
83 <label> 89 <label>
84 <input type="checkbox" name="reason" value="{{reasonId}}" /> 90 <input type="checkbox" name="reason" value="{{reasonId}}" />
85 {{value|translate(stringId, "Uninstallation reason")}} 91 {{value|translate(stringId, "Uninstallation reason")}}
86 </label> 92 </label>
87 </li> 93 </li>
88 {%- endfor %} 94 {%- endfor %}
89 <li> 95 <li>
90 <label> 96 <label>
91 <input id="reason-other" type="checkbox" name="reason" value="0v0" /> 97 <input id="reason-other" type="checkbox" name="reason" value="0v0" />
92 {{"Other, namely..."|translate("reason-other", "Last uninstallation re ason")}} 98 {{"Other, namely..."|translate("reason-other", "Last uninstallation re ason")}}
93 </label> 99 </label>
94 <textarea id="reason-other-input" class="hidden" name="reasonOther" plac eholder="{{"Please explain why you are uninstalling Adblock Plus"|translate("rea son-other-placeholder", "Textarea placeholder text, appears after selecting 'Oth er, namely...' option")}}"></textarea> 100 <div id="reason-other-container" class="hidden">
101 <textarea id="reason-other-input" name="reasonOther" maxlength="300" p laceholder="{{"Please explain why you are uninstalling Adblock Plus"|translate(" reason-other-placeholder", "Textarea placeholder text, appears after selecting ' Other, namely...' option")}}"></textarea>
102 <div>
103 {{"Characters remaining:"|translate("countdown-text", "Text of char acter limit counter appears after selecting 'Other, namely...' option")}}
104 <span id="characters-countdown"></span>
105 </div>
106 </div>
95 </li> 107 </li>
96 </ul> 108 </ul>
97 <button id="submit-form">{{"Submit"|translate("submit", "Submit button text" )}}</button> 109 <button id="submit-form">{{"Submit"|translate("submit", "Submit button text" )}}</button>
98 <span class="error-label">{{"Please select at least one of the options above "|translate("error-msg", "Error message, is being shown after submission if no i tem selected")}}</span> 110 <span class="error-label">{{"Please select at least one of the options above "|translate("error-msg", "Error message, is being shown after submission if no i tem selected")}}</span>
99 </form> 111 </form>
100 <p class="disclaimer"> 112 <p class="disclaimer">
101 {{"By clicking Submit, you are sending your response to Adblock Plus. Please see our <a href='/privacy'>privacy policy</a>."|translate("disclaimer", "Discla imer below form")}} 113 {{"By clicking Submit, you are sending your response to Adblock Plus. Please see our <a href='/privacy'>privacy policy</a>."|translate("disclaimer", "Discla imer below form")}}
102 </p> 114 </p>
103 </section> 115 </section>
OLDNEW
« no previous file with comments | « no previous file | pages/uninstalled-submit.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld