Issue #1234 - Remove 'CString' From 'ToLowerString()'

src/plugin/PluginUtil.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 37 matching lines @@
   ATL::CComBSTR locationUrl;
   if (FAILED(browser.get_LocationURL(&locationUrl)) || !locationUrl)
   {
     return std::wstring();
   }
   return std::wstring(locationUrl, locationUrl.Length());
 }
 
 std::wstring ToLowerString(const std::wstring& s)
 {
-  return ToWstring(ToCString(s).MakeLower());
+  std::wstring lower(s); // Copy the argument
+  /*
+   * C++11 provides that 'c_str()' returns the internal array in which the string holds its value.
+   * Thus we can modify in-place after casting away the 'const' modifier from 'c_str()'.
+   *
+   * Documentation for '_wcslwr_s' https://msdn.microsoft.com/en-us/library/y889wzfw.aspx
+   * This documentation is incorrect on an important point.
+   * Regarding parameter validation, it says "length of string" where it should say "length of buffer".
+   * The call below has argument "length + 1" to include the terminating null character in the buffer.
+   */
+  auto e = _wcslwr_s(const_cast<wchar_t*>(lower.c_str()), lower.length() + 1); // uses the current locale
+  if (e != 0)
+  {
+    throw std::logic_error("Error code returned from _wcslwr_s()");
+  }
+  return lower;
 }