Issue #1234 - Remove 'CString' From 'ToLowerString()'

test/plugin/UtilTest.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 53 matching lines @@
 
 TEST(BeginsWith, ExtraBad)
 {
   ASSERT_FALSE(BeginsWithForTesting(L"foo", L"foobar"));
 }
 
 TEST(BeginsWith, LongerBad)
 {
   ASSERT_FALSE(BeginsWithForTesting(L"foo", L"barfoo"));
 }
+
+TEST(ToLowerString, Empty)
+{
+  ASSERT_EQ(L"", ToLowerString(L""));
+}
+
+TEST(ToLowerString, NotEmpty)
+{
+  ASSERT_EQ(L"foo", ToLowerString(L"Foo"));

[Oleksandr, 2016/01/05 22:59:00]

Nit: why not test "FOO" instead? To make sure not only the first character was
lower cased.

[Eric, 2016/01/07 14:34:04]

Changed. Generally, when you partially modify data, you want to test both that
(1) what's supposed to be modified is modified and (2) what's not supposed to be
modified is not modified.

FWIW, I'd be more extensive here if this weren't a wrapper around a library
function.

+}
+
+TEST(ToLowerString, NullWithExtra)
+{
+  std::wstring input(L"\0BAR", 4);
+  ASSERT_EQ(4, input.length());
+
+  std::wstring actual;
+  ASSERT_NO_THROW({ actual = ToLowerString(input); });
+  // White-box tests for further verification of no-crash behavior
+  ASSERT_EQ(4, actual.length());
+  ASSERT_EQ(L"", std::wstring(actual.c_str()));
+}
+
+TEST(ToLowerString, InternalNull)
+{
+  std::wstring input(L"Foo\0BAR", 7);
+  ASSERT_EQ(7, input.length());
+
+  std::wstring actual;
+  ASSERT_NO_THROW({ actual = ToLowerString(input); });
+  // White-box tests for further verification of no-crash behavior
+  ASSERT_EQ(7, actual.length());
+  ASSERT_EQ(L"foo", std::wstring(actual.c_str()));
+}