Unified Diff: chrome/content/ui/sendReport.js
Issue 29333150:
Issue 3461 - Fixed: Issue Reporter assumes that RequestEntry.filter is a Filter instance, not a str… (Closed)
Patch Set: Addressed comment
Created Jan. 5, 2016, 9:49 a.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
no next file »
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: chrome/content/ui/sendReport.js |
| =================================================================== |
| --- a/chrome/content/ui/sendReport.js |
| +++ b/chrome/content/ui/sendReport.js |
| @@ -820,18 +820,24 @@ var subscriptionUpdateDataSource = |
| return; |
| FilterNotifier.removeListener(listener); |
| E("updateInProgress").hidden = "true"; |
| let filtersRemoved = false; |
| let requests = requestsDataSource.origRequests; |
| for (let i = 0; i < requests.length; i++) |
| - if (requests[i].filter && !requests[i].filter.subscriptions.filter(s => !s.disabled).length) |
| + { |
| + if (!requests[i].filter) |
| + continue; |
| + |
| + let filter = Filter.fromText(requests[i].filter); |
| + if (!filter.subscriptions.some(s => !s.disabled)) |
| filtersRemoved = true; |
| + } |
| if (filtersRemoved) |
| { |
| // Force the user to reload the page |
| E("updateFixedIssue").hidden = false; |
| document.documentElement.canAdvance = true; |
| let nextButton = document.documentElement.getButton("next"); |
« no previous file with comments
|
« no previous file
|
no next file »
|
no next file with comments »
