lib/ui.js - Issue 29333169: Issue 3407 - Don`t access content window when closing blockable items

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: lib/ui.js

Issue 29333169: Issue 3407 - Don`t access content window when closing blockable items (Closed)

Patch Set: Created Jan. 4, 2016, 7:36 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: lib/ui.js

===================================================================

--- a/lib/ui.js

+++ b/lib/ui.js

@@ -1750,18 +1750,20 @@ let UI = exports.UI =

let {addBottomBar, removeBottomBar, getBrowser} = require("appSupport");

let mustDetach = !addBottomBar || !removeBottomBar || !("abp-bottombar-container" in this.overlay);

let detach = mustDetach || Prefs.detachsidebar;

if (!detach && window.document.getElementById("abp-bottombar"))

{

removeBottomBar(window);

let browser = (getBrowser ? getBrowser(window) : null);

+ if (browser && "selectedBrowser" in browser)

+ browser = browser.selectedBrowser;

if (browser)

- browser.contentWindow.focus();

+ browser.focus();

}

else if (!detach)

{

addBottomBar(window, this.overlay["abp-bottombar-container"]);

let element = window.document.getElementById("abp-bottombar");

if (element)

{

element.setAttribute("width", Prefs.blockableItemsSize.width);

« no previous file with comments | « no previous file | no next file » | no next file with comments »