packagerGecko.py - Issue 29333368: Issue 3498 - Improve file mapping / skipping logic

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: packagerGecko.py

Issue 29333368: Issue 3498 - Improve file mapping / skipping logic (Closed)

Patch Set: Pass the skip parameter for both Gecko Files.read calls Created Jan. 12, 2016, 1:24 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: packagerGecko.py

diff --git a/packagerGecko.py b/packagerGecko.py

index 748bf2810e47663e26e9907c8dbdcfc47aeaff91..12af5405567bf839573f32cf68832321351f97eb 100644

--- a/packagerGecko.py

+++ b/packagerGecko.py

@@ -338,15 +338,17 @@ def createBuild(baseDir, type="gecko", outFile=None, locales=None, buildNum=None

'multicompartment': multicompartment,

}

+ skip = metadata.options('mapping') if metadata.has_section('mapping') else []

+ skip.append('chrome')

files = Files(getPackageFiles(params), getIgnoredFiles(params),

process=lambda path, data: processFile(path, data, params))

files['install.rdf'] = createManifest(params)

if metadata.has_section('mapping'):

files.readMappedFiles(metadata.items('mapping'))

- files.read(baseDir, skip=('chrome'))

+ files.read(baseDir, skip=skip)

for name, path in getChromeSubdirs(baseDir, params['locales']).iteritems():

if os.path.isdir(path):

- files.read(path, 'chrome/%s' % name)

+ files.read(path, 'chrome/%s' % name, skip=skip)

importLocales(params, files)

fixupLocales(params, files)

if not 'bootstrap.js' in files:

« packagerChrome.py ('K') | « packagerChrome.py ('k') | packagerSafari.py » ('j') | no next file with comments »