Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: chrome/content/ui/sendReport.js

Issue 29333389: Issue 3502 - Don`t use expression closures in Issue Reporter (Closed)
Patch Set: Created Jan. 12, 2016, 3:52 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/content/ui/sendReport.js
===================================================================
--- a/chrome/content/ui/sendReport.js
+++ b/chrome/content/ui/sendReport.js
@@ -376,30 +376,36 @@ var screenshotDataSource =
image.addEventListener("load", () => {
canvas.width = image.width + this.imageOffset * 2;
canvas.height = image.height + this.imageOffset * 2;
context.drawImage(image, this.imageOffset, this.imageOffset);
});
}
},
- get enabled() this._enabled,
+ get enabled()
+ {
+ return this._enabled
Thomas Greiner 2016/01/12 16:02:02 Detail: Missing semicolon (same below)
Wladimir Palant 2016/01/12 17:14:42 Done.
+ },
set enabled(enabled)
{
if (this._enabled == enabled)
return;
this._enabled = enabled;
this._canvas.style.opacity = this._enabled ? "" : "0.3"
E("screenshotMarkButton").disabled = !this._enabled;
E("screenshotRemoveButton").disabled = !this._enabled;
E("screenshotUndoButton").disabled = !this._enabled || !this._undoQueue.length;
},
- get selectionType() this._selectionType,
+ get selectionType()
+ {
+ return this._selectionType
+ },
set selectionType(type)
{
if (this._selectionType == type)
return;
// Abort selection already in progress
this.abortSelection();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld