compiled/ElemHideBase.h - Issue 29333474: Issue 4125 - [emscripten] Convert filter classes to C++

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: compiled/ElemHideBase.h

Issue 29333474: Issue 4125 - [emscripten] Convert filter classes to C++ (Closed)

Patch Set: Fixed some bugs and exposed/tested more properties Created Jan. 15, 2016, 3:40 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
(Empty)
	1 #ifndef ADBLOCKPLUS_ELEMHIDEBASE_H

	2 #define ADBLOCKPLUS_ELEMHIDEBASE_H

	3

	4 #include <cstddef>

	5 #include <string>

	6

	7 #include "ActiveFilter.h"

	8

	9 class ElemHideBase : public ActiveFilter

	10 {

	11 public:

	12 ElemHideBase(const std::u16string& text, size_t domainsEnd, size_t selectorSta rt);
	Felix Dahlke 2016/01/15 17:00:36 I'd prefer to largely stick to the 80 column rule I'd prefer to largely stick to the 80 column rule in new code. Wladimir Palant 2016/01/15 20:36:15 Done. Show quoted text On 2016/01/15 17:00:36, Felix Dahlke wrote: > I'd prefer to largely stick to the 80 column rule in new code. Done.
	13 static Type Parse(const std::u16string& text, size_t* domainsEnd, size_t* sele ctorStart);

	14 static ElemHideBase* Create(const std::u16string& text);

	15 };

	16

	17 #endif

OLD	NEW