Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Delta Between Two Patch Sets: compiled/InvalidFilter.h

Issue 29333474: Issue 4125 - [emscripten] Convert filter classes to C++ (Closed)
Left Patch Set: Fixed some bugs and exposed/tested more properties Created Jan. 15, 2016, 3:40 p.m.
Right Patch Set: Addressed comments from Patch Set 28 Created March 21, 2017, 10:04 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « compiled/Filter.cpp ('k') | compiled/InvalidFilter.cpp » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 #ifndef ADBLOCKPLUS_INVALIDFILTER_H 1 #pragma once
2 #define ADBLOCKPLUS_INVALIDFILTER_H
3
4 #include <string>
5 2
6 #include "Filter.h" 3 #include "Filter.h"
7 #include "tools.h"
8 4
9 class InvalidFilter : public Filter 5 class InvalidFilter : public Filter
10 { 6 {
11 public: 7 public:
12 InvalidFilter(const std::u16string& text, const std::u16string& reason); 8 explicit InvalidFilter(const String& text, const String& reason);
13 Type get_type(); 9 EMSCRIPTEN_KEEPALIVE const String& GetReason() const
14 const std::u16string get_reason()
15 { 10 {
16 return reason; 11 return mReason;
17 }; 12 };
18 private: 13 private:
19 std::u16string reason; 14 OwnedString mReason;
20 }; 15 };
21
22 #endif
LEFTRIGHT
« compiled/Filter.cpp ('k') | compiled/InvalidFilter.cpp » ('j') | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
This is Rietveld