compiled/ElemHideFilter.h - Issue 29333474: Issue 4125 - [emscripten] Convert filter classes to C++

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: compiled/ElemHideFilter.h

Issue 29333474: Issue 4125 - [emscripten] Convert filter classes to C++ (Closed)

Left Patch Set: Addressed comments, made String class slightly more sane, slightly cleaned up bindings.cpp Created Feb. 2, 2016, 5:48 p.m.

Right Patch Set: Addressed comments from Patch Set 28 Created March 21, 2017, 10:04 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 #ifndef ADBLOCK_PLUS_ELEM_HIDE_FILTER_H	1 #pragma once

2 #define ADBLOCK_PLUS_ELEM_HIDE_FILTER_H

3	2

4 #include <cstddef>	3 #include <cstddef>

5	4

6 #include "Filter.h"	5 #include "Filter.h"

7 #include "ElemHideBase.h"	6 #include "ElemHideBase.h"

8	7

9 class ElemHideFilter: public ElemHideBase	8 class ElemHideFilter: public ElemHideBase

10 {	9 {

11 public:	10 public:

12 ElemHideFilter(const String& text, String::size_type domainsEnd,	11 explicit ElemHideFilter(const String& text, const ElemHideBaseData& data);

13 String::size_type selectorStart);

14 Type GetType() const;

15 };	12 };

16

17 #endif

LEFT	RIGHT