compiled/RegExpFilter.h - Issue 29333474: Issue 4125 - [emscripten] Convert filter classes to C++

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: compiled/RegExpFilter.h

Issue 29333474: Issue 4125 - [emscripten] Convert filter classes to C++ (Closed)

Left Patch Set: Addressed comments from Patch Set 24 Created Dec. 6, 2016, 10:43 a.m.

Right Patch Set: Addressed comments from Patch Set 28 Created March 21, 2017, 10:04 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 #pragma once	1 #pragma once

2	2

3 #include "Filter.h"	3 #include "Filter.h"

4 #include "ActiveFilter.h"	4 #include "ActiveFilter.h"

5	5

6 enum class TrippleState {YES, NO, ANY};	6 enum class TrippleState {YES, NO, ANY};

7	7

8 struct RegExpFilterData	8 struct RegExpFilterData

9 {	9 {

10 mutable String::size_type mPatternStart;	10 mutable String::size_type mPatternStart;

(...skipping 67 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
78 {	78 {

79 private:	79 private:

80 void ParseSitekeys(const String& sitekeys) const;	80 void ParseSitekeys(const String& sitekeys) const;

81	81

82 protected:	82 protected:

83 RegExpFilterData mData;	83 RegExpFilterData mData;

84	84

85 DomainMap* GetDomains() const override;	85 DomainMap* GetDomains() const override;

86 SitekeySet* GetSitekeys() const override;	86 SitekeySet* GetSitekeys() const override;

87 public:	87 public:

88 RegExpFilter(Type type, const String& text, const RegExpFilterData& data);	88 explicit RegExpFilter(Type type, const String& text, const RegExpFilterData& d ata);

89 ~RegExpFilter();	89 ~RegExpFilter();

90 static Type Parse(DependentString& text, DependentString& error,	90 static Type Parse(DependentString& text, DependentString& error,

91 RegExpFilterData& data);	91 RegExpFilterData& data);

92 EMSCRIPTEN_KEEPALIVE static void InitJSTypes();	92 EMSCRIPTEN_KEEPALIVE static void InitJSTypes();

93 static OwnedString RegExpFromSource(const String& source);	93 static OwnedString RegExpFromSource(const String& source);

94 EMSCRIPTEN_KEEPALIVE bool Matches(const String& location, int typeMask,	94 EMSCRIPTEN_KEEPALIVE bool Matches(const String& location, int typeMask,

95 DependentString& docDomain, bool thirdParty, const String& sitekey) const;	95 DependentString& docDomain, bool thirdParty, const String& sitekey) const;

96 };	96 };

LEFT	RIGHT