Unified Diff: compiled/CommentFilter.cpp
Issue 29333474:
Issue 4125 - [emscripten] Convert filter classes to C++ (Closed)
Patch Set: Fixed some bugs and exposed/tested more properties
Created Jan. 15, 2016, 3:40 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« compiled/ActiveFilter.cpp ('K')
|
« compiled/CommentFilter.h ('k')
|
compiled/ElemHideBase.h » ('j')
|
compiled/ElemHideBase.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: compiled/CommentFilter.cpp |
| =================================================================== |
| new file mode 100644 |
| --- /dev/null |
| +++ b/compiled/CommentFilter.cpp |
| @@ -0,0 +1,28 @@ |
| +#include "CommentFilter.h" |
| + |
| +CommentFilter::CommentFilter(const std::u16string& text) |
| + : Filter(text) |
| +{ |
| +} |
| + |
| +Filter::Type CommentFilter::Parse(const std::u16string& text) |
| +{ |
| + if (text.length() && text[0] == u'!') |
| + return Type::COMMENT; |
| + else |
| + return Type::UNKNOWN; |
| +} |
| + |
| +CommentFilter* CommentFilter::Create(const std::u16string& text) |
| +{ |
| + Type type = Parse(text); |
| + if (type == Type::UNKNOWN) |
|
Felix Dahlke
2016/01/15 17:00:35
IMHO it'd make more sense to check for type != Typ
Wladimir Palant
2016/01/15 20:36:15
Done.
|
| + return nullptr; |
| + else |
| + return new CommentFilter(text); |
| +} |
| + |
| +Filter::Type CommentFilter::get_type() |
| +{ |
| + return Type::COMMENT; |
| +} |
« compiled/ActiveFilter.cpp ('K')
|
« compiled/CommentFilter.h ('k')
|
compiled/ElemHideBase.h » ('j')
|
compiled/ElemHideBase.h » ('J')
