Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: compiled/CSSPropertyFilter.h

Issue 29333474: Issue 4125 - [emscripten] Convert filter classes to C++ (Closed)
Patch Set: Optimized hash lookup performance a bit Created Feb. 8, 2016, 7:11 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiled/CSSPropertyFilter.h
===================================================================
new file mode 100644
--- /dev/null
+++ b/compiled/CSSPropertyFilter.h
@@ -0,0 +1,50 @@
+#pragma once
+
+#include <cstddef>
+
+#include "Filter.h"
+#include "ElemHideBase.h"
+
+struct CSSPropertyFilterData
+{
+ String::size_type mPrefixEnd;
+ String::size_type mRegexpStart;
+ String::size_type mRegexpEnd;
+ String::size_type mSuffixStart;
+
+ const DependentString GetSelectorPrefix(const String& text,
+ String::size_type selectorStart) const
+ {
+ return DependentString(text, selectorStart, mPrefixEnd - selectorStart);
+ }
+
+ const DependentString GetRegExpSource(const String& text) const
+ {
+ return DependentString(text, mRegexpStart, mRegexpEnd - mRegexpStart);
+ }
+
+ const DependentString GetSelectorSuffix(const String& text) const
+ {
+ return DependentString(text, mSuffixStart);
+ }
+};
+
+struct ElemHideData : ElemHideBaseData, CSSPropertyFilterData
+{
+};
+
+class CSSPropertyFilter: public ElemHideBase, protected CSSPropertyFilterData
+{
+public:
+ CSSPropertyFilter(const String& text, const ElemHideData& data);
+ Type GetType() const;
sergei 2016/02/17 12:54:32 Do you mind to add `override` (without `virtual`)
Wladimir Palant 2016/02/18 16:06:39 Done.
+ EMSCRIPTEN_KEEPALIVE OwnedString GetRegExpString() const;
+ EMSCRIPTEN_KEEPALIVE const DependentString GetSelectorPrefix() const
+ {
+ return CSSPropertyFilterData::GetSelectorPrefix(mText, mSelectorStart);
+ }
+ EMSCRIPTEN_KEEPALIVE const DependentString GetSelectorSuffix() const
+ {
+ return CSSPropertyFilterData::GetSelectorSuffix(mText);
+ }
+};

Powered by Google App Engine
This is Rietveld