Issue 3515 - Remove outdated hack ignoring sub-directories in lib/

packagerChrome.py

 # coding: utf-8
 
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 import sys
 import os
 import re
 import json
 import struct
 import io
 from StringIO import StringIO
 
 import packager
 from packager import readMetadata, getMetadataPath, getDefaultFileName, getBuildVersion, getTemplate, Files
 
 defaultLocale = 'en_US'
 
 def getIgnoredFiles(params):
-  result = set(('store.description',))
-
-  # Hack: ignore all lib subdirectories
-  libDir = os.path.join(params['baseDir'], 'lib')
-  for file in os.listdir(libDir):
-    if os.path.isdir(os.path.join(libDir, file)):
-      result.add(file)
-  return result
+  return ['store.description']

[Wladimir Palant, 2016/01/14 19:28:04]

This should still be a set - even with one entry, lookup in sets is more
efficient.

[Sebastian Noack, 2016/01/14 23:28:41]

Not that it matters with a single item, but done.

 
 def getPackageFiles(params):
   result = set(('_locales', 'icons', 'jquery-ui', 'lib', 'skin', 'ui', 'ext'))
 
   if params['devenv']:
     result.add('qunit')
 
   baseDir = params['baseDir']
   for file in os.listdir(baseDir):
     if file.endswith('.js') or file.endswith('.html') or file.endswith('.xml'):
@@ skipping 329 matching lines @@
     files['qunit/index.html'] = createScriptPage(params, 'testIndex.html.tmpl',
                                                  ('general', 'testScripts'))
 
   zipdata = files.zipToString()
   signature = None
   pubkey = None
   if keyFile != None:
     signature = signBinary(zipdata, keyFile)
     pubkey = getPublicKey(keyFile)
   writePackage(outFile, pubkey, signature, zipdata)