Issue 3587 - Use hiera_hash() to accumulate $adblockplus::users

modules/adblockplus/manifests/init.pp

 # == Class: adblockplus
 #
 # The adblockplus class and the associated adblockplus:: namespace are
 # used to integrate Puppet modules with each other, in order to assemble
 # the setups used by the Adblock Plus project.
 #
 # === Parameters:
 #
 # [*users*]
 #   A hash of adblockplus::user $name => $parameter items to set up in this
 #   context, i.e. via Hiera.
 #
 # === Examples:
 #
 #   class {'adblockplus':
 #     users => {
 #       'pinocchio' => {
 #         # see adblockplus::user
 #       },
 #     },
 #   }
 #
 class adblockplus (
-  $users = hiera('adblockplus::users', []),
+  $users = hiera_hash('adblockplus::users', []),

[Fred, 2016/01/27 15:50:32]

The default value should be an empty hash here instead of an empty array.

[mathias, 2016/01/27 15:57:25]

Acknowledged.

 ) {
 
   # Used as internal constant within adblockplus::* resources
   $directory = '/var/adblockplus'
 
   # A common location for directories specific to the adblockplus:: setups,
   # managed via Puppet, but accessible by all users with access to the system
   @file {$directory:
     ensure => 'directory',
     mode => 0755,
     owner => 'root',
   }
 
   # See modules/adblockplus/manifests/user.pp
   create_resources('adblockplus::user', $users)
 }