Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: metadata.common

Issue 29336084: Issue 2426 - Open block.html as a popup window (Closed)
Left Patch Set: Check callback exists outside of afterTabLoaded Created Feb. 13, 2016, 2:16 p.m.
Right Patch Set: Assume createData parameter has been given Created Feb. 17, 2016, 8:50 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « metadata.chrome ('k') | popup.js » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 [general] 1 [general]
2 version = 1.10.1 2 version = 1.10.2
3 backgroundScripts = lib/polyfills/url.js 3 backgroundScripts = lib/polyfills/url.js
4 lib/polyfills/promise.js 4 lib/polyfills/promise.js
5 lib/polyfills/fetch.js 5 lib/polyfills/fetch.js
6 ext/common.js 6 ext/common.js
7 ext/background.js 7 ext/background.js
8 lib/compat.js 8 lib/compat.js
9 lib/info.js 9 lib/info.js
10 lib/adblockplus.js 10 lib/adblockplus.js
11 lib/punycode.js 11 lib/punycode.js
12 lib/publicSuffixList.js 12 lib/publicSuffixList.js
(...skipping 20 matching lines...) Expand all
33 tests/url.js 33 tests/url.js
34 tests/signatures.js 34 tests/signatures.js
35 tests/cssEscaping.js 35 tests/cssEscaping.js
36 permissions = http://*/* https://*/* 36 permissions = http://*/* https://*/*
37 37
38 [contentScripts] 38 [contentScripts]
39 document_start = ext/common.js ext/content.js cssProperties.js include.preload.j s 39 document_start = ext/common.js ext/content.js cssProperties.js include.preload.j s
40 document_end = include.postload.js 40 document_end = include.postload.js
41 41
42 [mapping] 42 [mapping]
43 cssProperties.js = adblockplus/chrome/content/cssProperties.js 43 cssProperties.js = adblockpluscore/chrome/content/cssProperties.js
44 ext/content.js = chrome/ext/content.js 44 ext/content.js = chrome/ext/content.js
45 ext/popup.js = chrome/ext/popup.js 45 ext/popup.js = chrome/ext/popup.js
46 subscriptions.xml = adblockplus/chrome/content/ui/subscriptions.xml 46 subscriptions.xml = adblockpluscore/chrome/content/ui/subscriptions.xml
47 firstRun.html = adblockplusui/firstRun.html 47 firstRun.html = adblockplusui/firstRun.html
48 common.js = adblockplusui/common.js 48 common.js = adblockplusui/common.js
49 firstRun.js = adblockplusui/firstRun.js 49 firstRun.js = adblockplusui/firstRun.js
50 i18n.js = adblockplusui/i18n.js 50 i18n.js = adblockplusui/i18n.js
51 messageResponder.js = adblockplusui/messageResponder.js 51 messageResponder.js = adblockplusui/messageResponder.js
52 icons/detailed/abp-128.png = adblockplusui/skin/abp-128.png 52 icons/detailed/abp-128.png = adblockplusui/skin/abp-128.png
53 skin/common.css = adblockplusui/skin/common.css 53 skin/common.css = adblockplusui/skin/common.css
54 skin/firstRun.css = adblockplusui/skin/firstRun.css 54 skin/firstRun.css = adblockplusui/skin/firstRun.css
55 skin/ajax-loader.gif = adblockplusui/skin/ajax-loader.gif 55 skin/ajax-loader.gif = adblockplusui/skin/ajax-loader.gif
56 skin/background.png = adblockplusui/skin/background.png 56 skin/background.png = adblockplusui/skin/background.png
(...skipping 11 matching lines...) Expand all
68 skin/social/renren.png = adblockplusui/skin/social/renren.png 68 skin/social/renren.png = adblockplusui/skin/social/renren.png
69 skin/social/twitter.png = adblockplusui/skin/social/twitter.png 69 skin/social/twitter.png = adblockplusui/skin/social/twitter.png
70 skin/social/weibo.png = adblockplusui/skin/social/weibo.png 70 skin/social/weibo.png = adblockplusui/skin/social/weibo.png
71 qunit/qunit.js = adblockplustests/chrome/content/qunit.js 71 qunit/qunit.js = adblockplustests/chrome/content/qunit.js
72 qunit/qunit.css = adblockplustests/chrome/content/qunit.css 72 qunit/qunit.css = adblockplustests/chrome/content/qunit.css
73 73
74 [convert_js] 74 [convert_js]
75 lib/adblockplus.js = lib/prefs.js 75 lib/adblockplus.js = lib/prefs.js
76 lib/utils.js 76 lib/utils.js
77 lib/io.js 77 lib/io.js
78 adblockplus/lib/downloader.js 78 adblockpluscore/lib/downloader.js
79 adblockplus/lib/filterNotifier.js 79 adblockpluscore/lib/filterNotifier.js
80 adblockplus/lib/filterClasses.js 80 adblockpluscore/lib/filterClasses.js
81 adblockplus/lib/subscriptionClasses.js 81 adblockpluscore/lib/subscriptionClasses.js
82 adblockplus/lib/filterStorage.js 82 adblockpluscore/lib/filterStorage.js
83 adblockplus/lib/elemHide.js 83 adblockpluscore/lib/elemHide.js
84 adblockplus/lib/matcher.js 84 adblockpluscore/lib/matcher.js
85 adblockplus/lib/cssRules.js 85 adblockpluscore/lib/cssRules.js
86 adblockplus/lib/filterListener.js 86 adblockpluscore/lib/filterListener.js
87 adblockplus/lib/synchronizer.js 87 adblockpluscore/lib/synchronizer.js
88 adblockplus/lib/notification.js 88 adblockpluscore/lib/notification.js
89 adblockplus/lib/antiadblockInit.js 89 adblockpluscore/lib/antiadblockInit.js
90 lib/url.js 90 lib/url.js
91 lib/stats.js 91 lib/stats.js
92 lib/devtools.js 92 lib/devtools.js
93 lib/whitelisting.js 93 lib/whitelisting.js
94 lib/filterValidation.js 94 lib/filterValidation.js
95 lib/filterComposer.js 95 lib/filterComposer.js
96 lib/icon.js 96 lib/icon.js
97 lib/notificationHelper.js 97 lib/notificationHelper.js
98 lib/popupBlocker.js 98 lib/popupBlocker.js
99 lib/uninstall.js 99 lib/uninstall.js
100 --arg module=true source_repo=https://hg.adblockplus.org/adblockplus/ 100 --arg module=true source_repo=https://hg.adblockplus.org/adblockpluscore/
101 ext/common.js = ext/common.js chrome/ext/common.js 101 ext/common.js = ext/common.js chrome/ext/common.js
102 ext/background.js = ext/background.js chrome/ext/background.js --arg brace_style =expand 102 ext/background.js = ext/background.js chrome/ext/background.js --arg brace_style =expand
103 include.postload.js = subscriptionLink.postload.js blockElement.postload.js 103 include.postload.js = subscriptionLink.postload.js blockElement.postload.js
104 104
105 qunit/tests/adblockplus.js = adblockplustests/chrome/content/tests/domainRestric tions.js 105 qunit/tests/adblockplus.js = adblockplustests/chrome/content/tests/domainRestric tions.js
106 adblockplustests/chrome/content/tests/filterClasses.js 106 adblockplustests/chrome/content/tests/filterClasses.js
107 adblockplustests/chrome/content/tests/filterNotifier.js 107 adblockplustests/chrome/content/tests/filterNotifier.js
108 adblockplustests/chrome/content/tests/filterStorage.js 108 adblockplustests/chrome/content/tests/filterStorage.js
109 adblockplustests/chrome/content/tests/matcher.js 109 adblockplustests/chrome/content/tests/matcher.js
110 adblockplustests/chrome/content/tests/prefs.js 110 adblockplustests/chrome/content/tests/prefs.js
(...skipping 25 matching lines...) Expand all
136 addSubscription.label 136 addSubscription.label
137 addSubscriptionAdd.label 137 addSubscriptionAdd.label
138 addSubscriptionOther.label 138 addSubscriptionOther.label
139 acceptableAds2.label 139 acceptableAds2.label
140 viewList.label 140 viewList.label
141 readMore.label 141 readMore.label
142 adblockplus/chrome/locale/*/subscriptionSelection.dtd = location.label 142 adblockplus/chrome/locale/*/subscriptionSelection.dtd = location.label
143 title.label 143 title.label
144 adblockplus/chrome/locale/*/meta.properties = =name 144 adblockplus/chrome/locale/*/meta.properties = =name
145 adblockplusui/locale/*/firstRun.json = =* 145 adblockplusui/locale/*/firstRun.json = =*
LEFTRIGHT

Powered by Google App Engine
This is Rietveld