lib/devtools.js - Issue 29336084: Issue 2426 - Open block.html as a popup window

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: lib/devtools.js

Issue 29336084: Issue 2426 - Open block.html as a popup window (Closed)

Patch Set: Reduce callback checking boilerplate Created Feb. 15, 2016, 3:45 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: lib/devtools.js

diff --git a/lib/devtools.js b/lib/devtools.js

index c94cced25c2cf5b5544c933dd1caf6fc0ab6e558..76b887b0481ba0e5b0fcd15f78ab12b603887b83 100644

--- a/lib/devtools.js

+++ b/lib/devtools.js

@@ -37,7 +37,7 @@ function hasPanels()

function getActivePanel(page)

{

- let panel = panels[page._id];

+ let panel = panels[page.id];

if(panel && !panel.reload && !panel.reloading)

return panel;

return null;

@@ -210,7 +210,7 @@ exports.logWhitelistedDocument = function(page, url, typeMask, docDomain, filter

exports.hasPanel = function(page)

{

- return page._id in panels;

+ return page.id in panels;

};

function onBeforeRequest(details)

@@ -239,7 +239,7 @@ function onBeforeRequest(details)

function onLoading(page)

{

- let tabId = page._id;

+ let tabId = page.id;

let panel = panels[tabId];

// Reloading the tab is the only way that allows bypassing all caches, in

« no previous file with comments | « include.postload.js ('k') | lib/icon.js » ('j') | no next file with comments »