Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/devtools.js

Issue 29336084: Issue 2426 - Open block.html as a popup window (Closed)
Patch Set: Rebased, replaced search param with proper messaging Created Feb. 17, 2016, 8:04 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include.postload.js ('k') | lib/icon.js » ('j') | safari/ext/background.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/devtools.js
diff --git a/lib/devtools.js b/lib/devtools.js
index c94cced25c2cf5b5544c933dd1caf6fc0ab6e558..76b887b0481ba0e5b0fcd15f78ab12b603887b83 100644
--- a/lib/devtools.js
+++ b/lib/devtools.js
@@ -37,7 +37,7 @@ function hasPanels()
function getActivePanel(page)
{
- let panel = panels[page._id];
+ let panel = panels[page.id];
if(panel && !panel.reload && !panel.reloading)
return panel;
return null;
@@ -210,7 +210,7 @@ exports.logWhitelistedDocument = function(page, url, typeMask, docDomain, filter
*/
exports.hasPanel = function(page)
{
- return page._id in panels;
+ return page.id in panels;
};
function onBeforeRequest(details)
@@ -239,7 +239,7 @@ function onBeforeRequest(details)
function onLoading(page)
{
- let tabId = page._id;
+ let tabId = page.id;
let panel = panels[tabId];
// Reloading the tab is the only way that allows bypassing all caches, in
« no previous file with comments | « include.postload.js ('k') | lib/icon.js » ('j') | safari/ext/background.js » ('J')

Powered by Google App Engine
This is Rietveld