Issue 3671 - Split out contentBlockerList API

node_modules/url.js

Index: node_modules/url.js
diff --git a/node_modules/url.js b/node_modules/url.js
new file mode 100644
index 0000000000000000000000000000000000000000..d3c1dbaf7bd79d04cd733e1776903cd9779d6124
--- /dev/null
+++ b/node_modules/url.js
@@ -0,0 +1,22 @@
+/*

[Sebastian Noack, 2016/02/21 20:34:45]

Please correct me if I'm wrong, as I'm not too familiar with that whole node.js
universe either, but to me it seems that node_modules is only for modules
installed through npm, while own modules should go under lib.

[kzar, 2016/02/22 12:28:06]

The documentation[1] seems to say that while the lib/node/ and .node_libraries/
directories can also be used as well as node_modules/ it is for historic reasons
and discouraged. I think how the files are laid out now is more or less correct,
but like you I'm no expert.

1: https://nodejs.org/api/modules.html#modules_loading_from_the_global_folders

+ * This file is part of Adblock Plus <https://adblockplus.org/>,
+ * Copyright (C) 2006-2016 Eyeo GmbH
+ *
+ * Adblock Plus is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 3 as
+ * published by the Free Software Foundation.
+ *
+ * Adblock Plus is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+/** @module url */

[Sebastian Noack, 2016/02/21 20:34:45]

Since the existence of this module is just an implementation detail, I think, I
wouldn't want to have it documented, if we will ever generate documentation for
this project.

[kzar, 2016/02/22 12:28:06]

Done.

[kzar, 2016/02/22 12:28:06]

Done.

+
+"use strict";
+
+exports.getBaseDomain = hostname => require("tldjs").getDomain(hostname);

[Sebastian Noack, 2016/02/21 20:34:45]

How about a comment that this is mimicking the url module in adblockpluschrome
for compatibility?

[Sebastian Noack, 2016/02/21 20:34:45]

Nit: exports.getBaseDomain = require("tldjs").getDomain;

[kzar, 2016/02/22 12:28:06]

I did that originally but it didn't work. I've changed it, what do you think? (I
don't think it matters much either way.)

[kzar, 2016/02/22 12:28:06]

Done.