dependencies - Issue 29338009: Issue 3763 - Got rid of redundant "add-filters" message type

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: dependencies

Issue 29338009: Issue 3763 - Got rid of redundant "add-filters" message type (Closed)

Patch Set: Update adblockplusui dependency Created March 9, 2016, 3:38 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 _root = hg:https://hg.adblockplus.org/ git:https://github.com/adblockplus/	1 _root = hg:https://hg.adblockplus.org/ git:https://github.com/adblockplus/

2 _self = buildtools/ensure_dependencies.py	2 _self = buildtools/ensure_dependencies.py

3 buildtools = buildtools hg:becc043671e9 git:2548f2f	3 buildtools = buildtools hg:becc043671e9 git:2548f2f

4 adblockplus = adblockplus hg:f484b17f0a54 git:9a29618	4 adblockplus = adblockplus hg:f484b17f0a54 git:9a29618

5 adblockpluscore = adblockpluscore hg:4f1d2c299c10 git:1e1aa79	5 adblockpluscore = adblockpluscore hg:4f1d2c299c10 git:1e1aa79

6 adblockplusui = adblockplusui hg:49ac049b2b2f git:b845b0d	6 adblockplusui = adblockplusui hg:e23fe878fabb git:3079852
kzar 2016/03/09 16:58:27 This dependency update is not mentioned in the iss This dependency update is not mentioned in the issue and seems like an unrelated change? Sebastian Noack 2016/03/09 17:12:11 Well, the only relevant change in this dependency Show quoted text On 2016/03/09 16:58:27, kzar wrote: > This dependency update is not mentioned in the issue and seems like an unrelated > change? Well, the only relevant change in this dependency update are changes to filters.rawImport (and it's counter part for single filters, filters.add) this patch relies on. kzar 2016/03/09 17:15:51 OK, but mind mentioning that in the issue? Show quoted text On 2016/03/09 17:12:11, Sebastian Noack wrote: > On 2016/03/09 16:58:27, kzar wrote: > > This dependency update is not mentioned in the issue and seems like an > unrelated > > change? > > Well, the only relevant change in this dependency update are changes to > filters.rawImport (and it's counter part for single filters, filters.add) this > patch relies on. OK, but mind mentioning that in the issue? Sebastian Noack 2016/03/09 17:36:23 Done. Show quoted text On 2016/03/09 17:15:51, kzar wrote: > On 2016/03/09 17:12:11, Sebastian Noack wrote: > > On 2016/03/09 16:58:27, kzar wrote: > > > This dependency update is not mentioned in the issue and seems like an > > unrelated > > > change? > > > > Well, the only relevant change in this dependency update are changes to > > filters.rawImport (and it's counter part for single filters, filters.add) this > > patch relies on. > > OK, but mind mentioning that in the issue? Done.
7 adblockplustests = adblockplustests hg:95fa66491d7d git:b4902cd	7 adblockplustests = adblockplustests hg:95fa66491d7d git:b4902cd

OLD	NEW

« no previous file with comments | « block.js ('k') | no next file » | no next file with comments »