tox.ini - Issue 29338156: Issue 3754 - Initial setup of the python-abp repo.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: tox.ini

Issue 29338156: Issue 3754 - Initial setup of the python-abp repo. (Closed)

Left Patch Set: Update ignore files, describe testing in README.md and fix a typo in tox.ini. Created March 16, 2016, 3:56 p.m.

Right Patch Set: Remove pytest from qa dependencies in tox.ini, change "filterlist" to "filter list" Created March 17, 2016, 2:39 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 [tox]	1 [tox]

2 envlist = py27, py35, pypy, qa	2 envlist = py27, py35, pypy, qa

3	3

4 [testenv]	4 [testenv]

5 commands = py.test tests	5 commands = py.test tests

6 deps =	6 deps =

7 pytest	7 pytest

8	8

9 # This environment is for checking code quality: test coverage, PEP8, etc.	9 # This environment is for checking code quality: test coverage, PEP8, etc.

10 # We have to install our package in development mode so that pytest-cov can	10 # We have to install our package in development mode so that pytest-cov can

11 # find the .coverage file.	11 # find the .coverage file.

12 [testenv:qa]	12 [testenv:qa]

13 commands =	13 commands =

14 py.test --cov=abp tests	14 py.test --cov=abp tests

15 flake8 abp tests setup.py	15 flake8 abp tests setup.py

16 deps =	16 deps =

17 pytest
Sebastian Noack 2016/03/16 16:03:59 IIRC, dependencies are inherited from testenv here IIRC, dependencies are inherited from testenv here. So this line would be redundant, but better double check. Vasily Kuznetsov 2016/03/16 16:29:35 It works without this line although I'm not sure i Show quoted text On 2016/03/16 16:03:59, Sebastian Noack wrote: > IIRC, dependencies are inherited from testenv here. So this line would be > redundant, but better double check. It works without this line although I'm not sure if it's because pytest-cov requires pytest or because of inheritance. When it installs the dependencies it now says "qa installdeps: pytest-cov, flake8" so perhaps the former. But anyway, this line seems to be redundant.
18 pytest-cov	17 pytest-cov

19 flake8	18 flake8

20 usedevelop = true	19 usedevelop = true

LEFT	RIGHT