Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: background.js

Issue 29338503: Issue 3823 - Adapt message names used by "Block element" feature for consistency (Closed)
Patch Set: Rebased Created March 19, 2016, 7:41 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | block.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: background.js
===================================================================
--- a/background.js
+++ b/background.js
@@ -56,7 +56,7 @@
contexts: ["image", "video", "audio"],
onclick: function(page)
{
- page.sendMessage({type: "blockelement-context-menu-clicked"});
+ page.sendMessage({type: "composer.content.contextMenuClicked"});
}
};
@@ -124,7 +124,7 @@
{
switch (msg.type)
{
- case "blockelement-open-popup":
+ case "composer.openDialog":
ext.windows.create({
url: ext.getURL("block.html"),
left: 50,
@@ -141,7 +141,7 @@
if (popupPageId == removedPageId)
{
sender.page.sendMessage({
- type: "blockelement-popup-closed",
+ type: "composer.content.dialogClosed",
popupId: popupPageId
});
ext.pages.onRemoved.removeListener(onRemoved);
@@ -239,11 +239,11 @@
case "add-sitekey":
processKey(msg.token, sender.page, sender.frame);
break;
- case "report-html-page":
+ case "composer.ready":
htmlPages.set(sender.page, null);
refreshIconAndContextMenu(sender.page);
break;
- case "compose-filters":
+ case "composer.getFilters":
sendResponse(composeFilters({
tagName: msg.tagName,
id: msg.id,
@@ -291,7 +291,7 @@
// update icon when page changes location
ext.pages.onLoading.addListener(function(page)
{
- page.sendMessage({type: "blockelement-finished"});
+ page.sendMessage({type: "composer.content.finished"});
refreshIconAndContextMenu(page);
showNextNotificationForUrl(page.url);
});
« no previous file with comments | « no previous file | block.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld