Noissue - Make the options page respond to subscription title and homepage changes

messageResponder.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 42 matching lines @@
     catch (e)
     {
       return null;
     }
   }
 
   function convertObject(keys, obj)
   {
     var result = {};
     for (var i = 0; i < keys.length; i++)
-      result[keys[i]] = obj[keys[i]];
+    {
+      var key = keys[i];

[Sebastian Noack, 2016/04/05 19:09:54]

As per the comment in background.js we don't set the title anymore, to avoid
overriding it. However, that requires an addional check here. Otherwise the
title would still be overridden with undefined.

+      if (key in obj)
+        result[key] = obj[key];
+    }
     return result;
   }
 
   function convertSubscription(subscription)
   {
     var obj = convertObject(["disabled", "downloadStatus", "homepage",
                              "lastDownload", "title", "url"], subscription);
     obj.isDownloading = Synchronizer.isExecuting(subscription);
     return obj;
   }
@@ skipping 324 matching lines @@
         for (var i = 0; i < subscriptions.length; i++)
         {
           var subscription = subscriptions[i];
           if (subscription instanceof DownloadableSubscription)
             Synchronizer.execute(subscription, true);
         }
         break;
     }
   });
 })(this);