Noissue - Make the options page respond to subscription title and homepage changes

options.js

Index: options.js
===================================================================
--- a/options.js
+++ b/options.js
@@ -445,7 +445,9 @@
     if (knownSubscription)
     {
       for (var property in subscription)

[Thomas Greiner, 2016/04/06 13:51:18]

Detail: I know that this is valid JavaScript and I'm aware that we don't have
anything in that regard in the coding styles but it's a bit strange seeing this
Python-looking block in JavaScript because usually you would put braces around
blocks that include multiple lines.

It might be comparable to putting multiple statements into a single line (e.g.
`foo(), bar();`) which we would usually avoid even though it is valid JavaScript
and our coding style allows it.

[Sebastian Noack, 2016/04/06 17:26:29]

Done.

-        if (property != "title")
+        if (property == "title" && subscription.url in recommendationsMap)

[Thomas Greiner, 2016/04/06 13:51:18]

Detail: I noticed that there's a variable `subscriptionsUrl` above. Feel free to
decide whether you want to reuse (and rename) or remove it.

[Sebastian Noack, 2016/04/06 17:26:29]

Done.

+          knownSubscription.originalTitle = subscription.title;
+        else
           knownSubscription[property] = subscription[property];
     }
     else
@@ -975,14 +977,6 @@
         updateSubscription(subscription);
         updateShareLink();
         break;
-      case "lastDownload":
-      case "downloadStatus":
-      case "downloading":
-        updateSubscription(subscription);
-        break;
-      case "homepage":
-        // TODO: NYI
-        break;
       case "removed":
         var knownSubscription = subscriptionsMap[subscription.url];
         getAcceptableAdsURL(function(acceptableAdsUrl)
@@ -1006,8 +1000,8 @@
           collections.filterLists.removeItem(knownSubscription);
         });
         break;
-      case "title":
-        // TODO: NYI
+      default:
+        updateSubscription(subscription);
         break;
     }
   }