Noissue - Added flake8-abp and pep8-naming extension and fix reported warnings

tests/test_render_script.py

 # This file is part of Adblock Plus <https://adblockplus.org/>,
 # Copyright (C) 2006-2016 Eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
@@ skipping 25 matching lines @@
 
 @pytest.fixture
 def rootdir(tmpdir):
     """Directory with prepared list fragments."""
     rootdir = tmpdir.join('root')
     rootdir.mkdir()
     # Simple file with just `Ok` and a non-ascii unicode character in it.
     rootdir.join('simple.txt').write('[Adblock]\nOk')
     # Fragment with a non-ascii character.
     rootdir.join('unicode.txt').write(
-        '[Adblock]\n\u1234'.encode('utf-8'), mode='wb')
+        u'[Adblock]\n\u1234'.encode('utf-8'), mode='wb')

[Sebastian Noack, 2016/05/12 15:31:03]

Since, for whatever reason, the qa env did run with Python 3 for me I didn't
spotted those: '\u1234' is the same as '\\u1234' since \u has no meaning in
non-unicode strings, hence the backslash is just interpreted as backslash and
the literal doesn't match repr() anymore. So this isn't only against our coding
style, but also rendered this test useless on Python 2. ;)

[Sebastian Noack, 2016/05/27 12:54:55]

I reverted changes of patch set 2. My conclusion above is wrong, as this file
uses "from __future__ import unicode_literals" which flake8-abp is going to
account for with issue 4404.

     # Fragment with an include.
     rootdir.join('includer.txt').write('[Adblock]\n%include inc:includee.txt%')
     # Fragment that includes a circular include file.
     rootdir.join('circ.txt').write('[Adblock]\n%include inc:circular.txt%')
     # Fragment that includes a file with broken include.
     rootdir.join('brk.txt').write('[Adblock]\n%include inc:broken.txt%')
     # Source directory for includes.
     incdir = rootdir.join('inc')
     incdir.mkdir()
     # Fragment that's included into includer.txt.
     incdir.join('includee.txt').write('I am included!')
     # Fragment that has a broken include.
     incdir.join('broken.txt').write('%include missing.txt%')
     # Fragment that includes itself.
     incdir.join('circular.txt').write('%include circular.txt%')
     return rootdir
 
 
 @pytest.fixture
 def webserver_port(tmpdir, request):
     """Serve fragments via HTTP on a random port (return the port number)."""
-    Handler = SimpleHTTPServer.SimpleHTTPRequestHandler
-    httpd = SocketServer.TCPServer(("", 0), Handler)
+    handler = SimpleHTTPServer.SimpleHTTPRequestHandler
+    httpd = SocketServer.TCPServer(('', 0), handler)
     port = httpd.socket.getsockname()[1]
     # Create some files to serve.
     webroot = tmpdir.join('webroot')
     webroot.mkdir()
-    webroot.join('inc.txt').write('Web \u1234'.encode('utf-8'), mode='wb')
+    webroot.join('inc.txt').write(u'Web \u1234'.encode('utf-8'), mode='wb')
     webroot.join('metainc.txt').write(
         '%include http://localhost:{}/inc.txt%'.format(port))
     # Change to this directory and start the webserver in another thread.
     os.chdir(str(webroot))
     thread = threading.Thread(target=httpd.serve_forever)
     thread.setDaemon(True)
     thread.start()
     # Make sure we shut it down at the end of the test.
     request.addfinalizer(httpd.shutdown)
     return port
@@ skipping 15 matching lines @@
 
 def test_render_no_includes(rootdir, dstfile):
     run_script(str(rootdir.join('simple.txt')), str(dstfile))
     result = dstfile.read()
     assert 'Ok' in result
     assert '! Checksum:' in result
 
 
 def test_render_unicode(rootdir, dstfile):
     code, err = run_script(str(rootdir.join('unicode.txt')), str(dstfile))
-    assert '\u1234' in dstfile.read(mode='rb').decode('utf-8')
+    assert u'\u1234' in dstfile.read(mode='rb').decode('utf-8')
 
 
 def test_render_with_includes(rootdir, dstfile):
     run_script(str(rootdir.join('includer.txt')), str(dstfile),
                '-i', 'inc=' + str(rootdir.join('inc')))
     assert 'I am included!' in dstfile.read()
 
 
 def test_render_with_includes_relative(rootdir, dstfile):
     run_script('includer.txt', str(dstfile), '-i', 'inc=inc', cwd=str(rootdir))
@@ skipping 50 matching lines @@
     assert err == "Unknown source: 'foo'\n"
 
 
 @pytest.mark.tryfirst
 @pytest.mark.slowtest
 def test_web_include(rootdir, dstfile, webserver_port):
     url = 'http://localhost:{}/metainc.txt'.format(webserver_port)
     webinc = rootdir.join('webinc.txt')
     webinc.write('[Adblock]\n%include {}%'.format(url))
     code, err = run_script(str(webinc), str(dstfile))
-    assert 'Web \u1234' in dstfile.read(mode='rb').decode('utf-8')
+    assert u'Web \u1234' in dstfile.read(mode='rb').decode('utf-8')
 
 
 @pytest.mark.slowtest
 def test_failed_web_include(rootdir, dstfile, webserver_port):
     url = 'http://localhost:{}/missing.txt'.format(webserver_port)
     webinc = rootdir.join('webinc.txt')
     webinc.write('[Adblock]\n%include {}%'.format(url))
     code, err = run_script(str(webinc), str(dstfile))
     assert code == 1
     assert err.startswith(
         "HTTP 404 Not found: '{0}' when including '{0}'".format(url))