Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Side by Side Diff: autotest/test_abprewrite_autoload.js
Issue
29345403
:
Issue 4088 - JSHydra-generated module scopes shouldn't be called immediately (Closed)
Patch Set: Automatically load some modules if specified
Created May 31, 2016, 1:46 p.m.
Left:
Base
Patch Set 1: None
Patch Set 2: Automatically load some modules if specified
Patch Set 3: Renamed callback
Right:
Patch Set 1: None
Patch Set 2: Automatically load some modules if specified
Patch Set 3: Renamed callback
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
autotest/test_abprewrite_autoload.js
autotest/test_abprewrite_autoload.js.expected
autotest/test_abprewrite_module.js.expected
jshydra.js
scripts/abprewrite.js
View unified diff
|
Download patch
« no previous file with comments
|
« no previous file
|
autotest/test_abprewrite_autoload.js.expected »
('j') |
jshydra.js »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
// Arguments: --trueast --arg autoload=foo,bar autotest/abprewrite_source.js
2
// Name: ABP rewriting test with automatic module loading
3
4
include("../scripts/abprewrite.js");
OLD
NEW
« no previous file with comments
|
« no previous file
|
autotest/test_abprewrite_autoload.js.expected »
('j') |
jshydra.js »
('J')
Edit Message
Issue 29345403: Issue 4088 - JSHydra-generated module scopes shouldn't be called immediately (Closed)
Created May 31, 2016, 11:36 a.m. by Wladimir Palant
Modified May 31, 2016, 3:07 p.m.
Reviewers kzar
Base URL:
Comments: 3
+ 1 drafts
This is Rietveld