Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Side by Side Diff: jni/Application.mk
Issue
29345540
:
Issue 4030 - Move JNI bindings into separate library project (Closed)
Patch Set: Changeset in adblockplusandroid repo
Created July 22, 2016, 12:10 p.m.
Left:
Base
Patch Set 1: None
Patch Set 2: Changeset in adblockplusandroid repo
Patch Set 3: Additional changes to libadblockplus-android with Diego's suggestions
Right:
Patch Set 1: None
Patch Set 2: Changeset in adblockplusandroid repo
Patch Set 3: Additional changes to libadblockplus-android with Diego's suggestions
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
README.md
build.xml
dependencies
jni/Android.mk
jni/Application.mk
jni/JniCallbacks.h
jni/JniCallbacks.cpp
jni/JniEventCallback.cpp
jni/JniFilter.cpp
jni/JniFilterChangeCallback.cpp
jni/JniFilterEngine.cpp
jni/JniJsEngine.cpp
jni/JniJsValue.h
jni/JniJsValue.cpp
jni/JniLogSystem.cpp
jni/JniNotification.cpp
jni/JniShowNotificationCallback.cpp
jni/JniSubscription.cpp
jni/JniUpdateAvailableCallback.cpp
jni/JniUpdateCheckDoneCallback.cpp
jni/JniWebRequest.cpp
jni/Utils.h
jni/Utils.cpp
project.properties
src/org/adblockplus/android/ABPEngine.java
src/org/adblockplus/android/AndroidFilterChangeCallback.java
src/org/adblockplus/android/AndroidUpdateAvailableCallback.java
src/org/adblockplus/android/AndroidUpdateCheckDoneCallback.java
src/org/adblockplus/android/AndroidWebRequest.java
src/org/adblockplus/android/AppUtils.java
src/org/adblockplus/android/Utils.java
src/org/adblockplus/libadblockplus/AdblockPlusException.java
src/org/adblockplus/libadblockplus/AppInfo.java
src/org/adblockplus/libadblockplus/Disposable.java
src/org/adblockplus/libadblockplus/Disposer.java
src/org/adblockplus/libadblockplus/EventCallback.java
src/org/adblockplus/libadblockplus/Filter.java
src/org/adblockplus/libadblockplus/FilterChangeCallback.java
src/org/adblockplus/libadblockplus/FilterEngine.java
src/org/adblockplus/libadblockplus/HeaderEntry.java
src/org/adblockplus/libadblockplus/JniExceptionHandler.java
src/org/adblockplus/libadblockplus/JsEngine.java
src/org/adblockplus/libadblockplus/JsValue.java
src/org/adblockplus/libadblockplus/LogSystem.java
src/org/adblockplus/libadblockplus/Notification.java
src/org/adblockplus/libadblockplus/ServerResponse.java
src/org/adblockplus/libadblockplus/ShowNotificationCallback.java
src/org/adblockplus/libadblockplus/Subscription.java
src/org/adblockplus/libadblockplus/UpdateAvailableCallback.java
src/org/adblockplus/libadblockplus/UpdateCheckDoneCallback.java
src/org/adblockplus/libadblockplus/WebRequest.java
src/org/apache/commons/lang/CharUtils.java
src/org/apache/commons/lang/StringEscapeUtils.java
src/org/apache/commons/lang/StringUtils.java
View unified diff
|
Download patch
« dependencies
('K') |
« jni/Android.mk
('k') |
jni/JniCallbacks.h »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
APP_STL := c++_static
2
APP_CPPFLAGS := -fexceptions
3
APP_ABI := armeabi-v7a x86
4
APP_PLATFORM := android-9
OLD
NEW
« dependencies
('K') |
« jni/Android.mk
('k') |
jni/JniCallbacks.h »
('j') |
no next file with comments »
Edit Message
Issue 29345540: Issue 4030 - Move JNI bindings into separate library project (Closed)
Created June 3, 2016, 1:42 p.m. by anton
Modified Sept. 8, 2017, 11:10 a.m.
Reviewers: diegocarloslima, Felix Dahlke
Base URL:
Comments: 12
This is Rietveld