Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: README.md

Issue 29345636: Issue 1414 - Document how to build libadblockplus for Android (Closed)
Patch Set: With some Sergey's suggestions Created June 9, 2016, 11:36 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: README.md
===================================================================
--- a/README.md
+++ b/README.md
@@ -10,16 +10,30 @@
retrieved and updated during the build process, but you can also manually update
them by running the following:
./ensure_dependencies.py
Building
--------
+### Supported compilers
+
+You need a C++11 compatible compiler to build libadblockplus.
+
+The compilation was tested with the following compilers:
+* g++ 4.8
+* Microsoft Visual Studio 2010, 2012
+* clang 3.4 for Android (from android-ndk-r9, android-ndk-r10c)
+* clang 3.6 for OS X
sergei 2016/06/10 11:36:01 Could you please also add yet one line here? * To
anton 2016/06/14 07:16:47 Acknowledged.
+
+You can download *android-ndk-r10c* for [Win 32](http://dl.google.com/android/ndk/android-ndk-r10c-windows-x86.exe), [Win 64](http://dl.google.com/android/ndk/android-ndk-r10c-windows-x86_64.exe), [OSX](http://dl.google.com/android/ndk/android-ndk-r10c-darwin-x86_64.bin), [Linux 32](http://dl.google.com/android/ndk/android-ndk-r10c-linux-x86.bin), [Linux 64](http://dl.google.com/android/ndk/android-ndk-r10c-linux-x86_64.bin).
Wladimir Palant 2016/06/10 21:54:55 I think this is getting confusing as it sort of im
anton 2016/06/14 07:30:30 can you please explain what makes you think about
sergei 2016/06/14 08:05:29 Yeah, the links for windows were also confusing me
anton 2016/06/14 08:07:29 Acknowledged.
+
+If you have a question about another compiler please [create an issue](https://issues.adblockplus.org/).
Wladimir Palant 2016/06/10 21:54:55 While you didn't add this sentence: Are we serious
anton 2016/06/14 07:16:47 i've just left this sentence as it was and i agree
sergei 2016/06/14 08:05:29 Yes, I agree. Just in case, I would like to preci
+
### Unix
All you need is Python 2.7 and Make:
make
The default target architecture is x64. On a 32 bit system, run:
@@ -46,27 +60,27 @@
`build\ia32\libadblockplus.sln` (solution for the 32 bit build) and
`build\x64\libadblockplus.sln` (solution for the 64 bit build). Unfortunately,
V8 doesn't support creating both from the same project files.
* Open `build\ia32\libadblockplus.sln` or `build\x64\libadblockplus.sln` in
Visual Studio and build the solution there. Alternatively you can use the
`msbuild` command line tool, e.g. run `msbuild /m build\ia32\libadblockplus.sln`
from the Visual Studio Developer Command Prompt to create a 32 bit debug build.
-### Supported compilers
+### Building for Android
-You need a C++11 compatible compiler to build libadblockplus.
+First set ANDROID_NDK_ROOT environment variable to your Android NDK directory.
-The compilation was tested with the following compilers:
-* g++ 4.8
-* Microsoft Visual Studio 2010, 2012
-* clang 3.4 for Android (from android-ndk-r9)
-* clang 3.6 for OS X
+To build for *x86* arch run:
-If you have a question about another compiler please [create an issue](https://issues.adblockplus.org/).
+ make android_x86
+
+To build for *arm* arch run:
+
+ make android_arm
Usage
-----
You can use libadblockplus to build an ad blocker. Or, strictly speaking, a web
content filter. Just like Adblock Plus, it can detect resources that should be
blocked based on their URL and context information, and generate CSS selectors
to hide DOM elements.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld